[GH-ISSUE #1194] Ability to modify queries #624

New issue

Closed

opened 2026-03-15 23:30:58 +03:00 by kerem · 2 comments

kerem commented

2026-03-15 23:30:58 +03:00

Owner

Originally created by @leshow on GitHub (Aug 24, 2020).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1194

I'm happy to write a PR for this if it's something you'd consider accepting, just let me know how you'd like to do it

Is your feature request related to a problem? Please describe.
I have a need to remove a query from a Message and replace it with another

Describe the solution you'd like
Mutable access to the queries field would work, or a remove_queries/set_queries method or something like that

Describe alternatives you've considered
The only alternative I can see is to make a brand new message then add everything but the query from the original only

Originally created by @leshow on GitHub (Aug 24, 2020). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1194 I'm happy to write a PR for this if it's something you'd consider accepting, just let me know how you'd like to do it **Is your feature request related to a problem? Please describe.** I have a need to remove a query from a `Message` and replace it with another **Describe the solution you'd like** Mutable access to the queries field would work, or a `remove_queries`/`set_queries` method or something like that **Describe alternatives you've considered** The only alternative I can see is to make a brand new message then add everything but the query from the original only

kerem

2026-03-15 23:30:58 +03:00

closed this issue
added the
crate:proto

question
labels

kerem commented

2026-03-15 23:31:14 +03:00

Author

Owner

@bluejekyll commented on GitHub (Aug 24, 2020):

I think we added this in 0.20, there is an alpha release of that if you want to try it out: https://docs.rs/trust-dns-proto/0.20.0-alpha.1/trust_dns_proto/op/message/struct.Message.html#method.queries_mut

Will that meet your needs?

@bluejekyll commented on GitHub (Aug 24, 2020): I think we added this in 0.20, there is an alpha release of that if you want to try it out: https://docs.rs/trust-dns-proto/0.20.0-alpha.1/trust_dns_proto/op/message/struct.Message.html#method.queries_mut Will that meet your needs?

kerem commented

2026-03-15 23:31:19 +03:00

Author

Owner

@leshow commented on GitHub (Aug 24, 2020):

Oh, haha, I'm pretty sure I added this actually. I totally forgot I added it for queries! Yes that works.

@leshow commented on GitHub (Aug 24, 2020): Oh, haha, I'm pretty sure I added this actually. I totally forgot I added it for queries! Yes that works.