[GH-ISSUE #1138] Parsing EDNS OPT fails with zero length option #611

New issue

Closed

opened 2026-03-15 23:27:42 +03:00 by kerem · 2 comments

kerem commented

2026-03-15 23:27:42 +03:00

Owner

Originally created by @TheEnbyperor on GitHub (Jun 19, 2020).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1138

Describe the bug
A EDNS option with zero length will fail parsing.

To Reproduce
DIG with +nsid option.
Generates the warning that follows:
WARN trust_dns_proto::rr::rdata::opt > incomplete or poorly formatted EDNS options: Data { code: NSID, length: 0, collected: [0, 10, 0, 8, 34, 143, 97, 69, 174, 26, 243, 49] }

Expected behavior
Parsing the NSID as present and of zero length.

System:

OS: Nixos
Architecture: x86_64
Version: N/A
rustc version: 1.44.0-nightly (dbf8b6bf1 2020-04-19)

Version:
Crate: proto
Version: 0.19

Additional context
Problem appears to be around line 238 in rr:rdata::opt

Originally created by @TheEnbyperor on GitHub (Jun 19, 2020). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1138 **Describe the bug** A EDNS option with zero length will fail parsing. **To Reproduce** DIG with `+nsid` option. Generates the warning that follows: ` WARN trust_dns_proto::rr::rdata::opt > incomplete or poorly formatted EDNS options: Data { code: NSID, length: 0, collected: [0, 10, 0, 8, 34, 143, 97, 69, 174, 26, 243, 49] }` **Expected behavior** Parsing the NSID as present and of zero length. **System:** - OS: Nixos - Architecture: x86_64 - Version: N/A - rustc version: 1.44.0-nightly (dbf8b6bf1 2020-04-19) **Version:** Crate: proto Version: 0.19 **Additional context** Problem appears to be around [line 238 in rr:rdata::opt](https://github.com/bluejekyll/trust-dns/blob/master/crates/proto/src/rr/rdata/opt.rs#L238)

kerem

2026-03-15 23:27:42 +03:00

closed this issue
added the
bug

crate:proto
labels

kerem commented

2026-03-15 23:27:58 +03:00

Author

Owner

@bluejekyll commented on GitHub (Jun 19, 2020):

There is a stalled PR to fix this: #744

Not sure what the state of that is.

@bluejekyll commented on GitHub (Jun 19, 2020): There is a stalled PR to fix this: #744 Not sure what the state of that is.

kerem commented

2026-03-15 23:28:03 +03:00

Author

Owner

@TheEnbyperor commented on GitHub (Jun 21, 2020):

Ah excellent, will verify this actually fixes it sometime this week.

@TheEnbyperor commented on GitHub (Jun 21, 2020): Ah excellent, will verify this actually fixes it sometime this week.

kerem referenced this issue

2026-03-16 02:12:43 +03:00

[PR #611] [MERGED] remove exec flag on non-exec files #1551