[GH-ISSUE #1002] Resolver & Proto seem to depend unnecessarily on `futures-executor` #588

New issue

Closed

opened 2026-03-15 23:19:35 +03:00 by kerem · 1 comment

kerem commented

2026-03-15 23:19:35 +03:00

Owner

Originally created by @antonylsg on GitHub (Jan 29, 2020).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1002

Hello,

It's my first issue. I hope to do it right.

It seems that Resolver and Proto depend on futures-executor but do not use it. So why not removing it from their dependency graph?

futures 0.3 uses ["std", "async-await", "executor"] as default features, so we could replace:

futures = "0.3"

for both (Resolver and Proto) by:

futures = { version = "0.3", default-features = false, features = ["std"] }

It should slightly improve the compilation time.

Originally created by @antonylsg on GitHub (Jan 29, 2020). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1002 Hello, It's my first issue. I hope to do it right. It seems that Resolver and Proto depend on `futures-executor` but do not use it. So why not removing it from their dependency graph? `futures` 0.3 uses `["std", "async-await", "executor"]` as default features, so we could replace: ```toml futures = "0.3" ``` for both (Resolver and Proto) by: ```toml futures = { version = "0.3", default-features = false, features = ["std"] } ``` It should slightly improve the compilation time.

kerem closed this issue

2026-03-15 23:19:41 +03:00

kerem commented

2026-03-15 23:19:47 +03:00

Author

Owner

@bluejekyll commented on GitHub (Jan 29, 2020):

I think this was being used in tests at one point, but that may have change. If you’d like to submit a PR, and it passes CI then that would be enough of a test to prove that it’s no longer used there.

Thanks for the issue!

@bluejekyll commented on GitHub (Jan 29, 2020): I think this was being used in tests at one point, but that may have change. If you’d like to submit a PR, and it passes CI then that would be enough of a test to prove that it’s no longer used there. Thanks for the issue!

kerem referenced this issue

2026-03-16 02:11:55 +03:00

[PR #588] [MERGED] Trust dns proto 0.5 alpha.4 #1540