[GH-ISSUE #994] resolv_conf #586

Closed
opened 2026-03-15 23:18:13 +03:00 by kerem · 4 comments
Owner

Originally created by @chunyingw on GitHub (Jan 16, 2020).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/994

Ben,
I notice that on Fuchsia it emits ERROR winutil (can't find repo path for winutil) when it loads crates from crates.io. The reason it is loaded is because trust-dns-resolver->resolv-conf->hostname(0.15.0)->winutil.

resolv-conf crate is used for unix, so it won't be used on Fuchsia anyway. However it's ugly to see this error message. I don't understand why Fuchsia complains this even though it only tries to fetch the crate and not uses it. I will dig into this.

Meanwhile I'd like to hear your advice on how to solve it in different ways:
Option1. In trust-dns-resolver, I may add a feature like unix-resolver-conf which contains resolv-conf and it will be part of the default features, in this way Fuchsia won't try to fetch this crate at all, so the error message will be gone.

Option2. I see the latest version of hostname 0.30.0 does not depend on wintuil, it seems if resolv-conf bumps its hostname dependency version from 0.15.0 to 0.30.0. It will work. I see resolv-conf was last updated one year ago, not sure if the owner is actively maintaining it.

The bottom line is with the PR#993 being part of the published version, I think I will be able to build trust-dns-proto and trust-dns-resolver (grabbing from crates.io instead of patching) on Fuchsia successfully, but I will see this ERROR winutil (can't find repo path for winutil) message when update the crates from crates.io.

Originally created by @chunyingw on GitHub (Jan 16, 2020). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/994 Ben, I notice that on Fuchsia it emits `ERROR winutil (can't find repo path for winutil)` when it loads crates from crates.io. The reason it is loaded is because `trust-dns-resolver`->`resolv-conf`->`hostname(0.15.0)`->winutil. resolv-conf crate is used for unix, so it won't be used on Fuchsia anyway. However it's ugly to see this error message. I don't understand why Fuchsia complains this even though it only tries to fetch the crate and not uses it. I will dig into this. Meanwhile I'd like to hear your advice on how to solve it in different ways: Option1. In trust-dns-resolver, I may add a feature like unix-resolver-conf which contains `resolv-conf` and it will be part of the default features, in this way Fuchsia won't try to fetch this crate at all, so the error message will be gone. Option2. I see the latest version of `hostname 0.30.0` does not depend on wintuil, it seems if resolv-conf bumps its hostname dependency version from 0.15.0 to 0.30.0. It will work. I see `resolv-conf` was last updated one year ago, not sure if the owner is actively maintaining it. The bottom line is with the PR#993 being part of the published version, I think I will be able to build trust-dns-proto and trust-dns-resolver (grabbing from crates.io instead of patching) on Fuchsia successfully, but I will see this `ERROR winutil (can't find repo path for winutil)` message when update the crates from crates.io.
kerem closed this issue 2026-03-15 23:18:18 +03:00
Author
Owner

@chunyingw commented on GitHub (Jan 16, 2020):

update: On Fuchsia side, wintil is vendored(loaded) successfully, the above error is emit during license validation. winuil is MIT licensed, I think it's okay. It could just be how the checking script is written that cause the issue. I will look further.

<!-- gh-comment-id:575216216 --> @chunyingw commented on GitHub (Jan 16, 2020): update: On Fuchsia side, wintil is vendored(loaded) successfully, the above error is emit during license validation. winuil is MIT licensed, I think it's okay. It could just be how the checking script is written that cause the issue. I will look further.
Author
Owner

@bluejekyll commented on GitHub (Jan 16, 2020):

Ok. Ive just published 0.19.1. I’m open to options here.

<!-- gh-comment-id:575219245 --> @bluejekyll commented on GitHub (Jan 16, 2020): Ok. Ive just published 0.19.1. I’m open to options here.
Author
Owner

@chunyingw commented on GitHub (Jan 16, 2020):

Update: with the version 0.19.1, I am able to port trust-dns-proto and trust-dns-resolver onto Fuchsia. Hooray!

For winutil (verison 0.1.1), Fuchsia is looking for a file like 'LICNESE` or such to do the validation, and this file is missing from the repo (version 0.1.1). That's why I see that error message.

I will see if it's possible I update the script on Fuchsia and get approved first. Then I don't need to make changes to trust-dns-resolver.
Otherwise, I will make resolv-conf optional.

<!-- gh-comment-id:575248382 --> @chunyingw commented on GitHub (Jan 16, 2020): Update: with the version 0.19.1, I am able to port `trust-dns-proto` and `trust-dns-resolver` onto Fuchsia. Hooray! For winutil (verison 0.1.1), Fuchsia is looking for a file like 'LICNESE` or such to do the validation, and this file is missing from the repo (version 0.1.1). That's why I see that error message. I will see if it's possible I update the script on Fuchsia and get approved first. Then I don't need to make changes to trust-dns-resolver. Otherwise, I will make resolv-conf optional.
Author
Owner

@chunyingw commented on GitHub (Jan 16, 2020):

After some research I think our script is doing the right thing.
Essentially it's validating against LICENSE file and does not trust the license field in the Cargo.toml file.
[winutil] (https://bitbucket.org/DaveLancaster/winutil/src/master/) is missing the LICENSE* file from both the published version and github repo.

So I will work on making resolv-conf optional for trust-dns-resolver now.

<!-- gh-comment-id:575295810 --> @chunyingw commented on GitHub (Jan 16, 2020): After some research I think our script is doing the right thing. Essentially it's validating against `LICENSE` file and does not trust the `license` field in the `Cargo.toml` file. [`winutil`] (https://bitbucket.org/DaveLancaster/winutil/src/master/) is missing the LICENSE* file from both the published version and github repo. So I will work on making `resolv-conf` optional for `trust-dns-resolver` now.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#586
No description provided.