[GH-ISSUE #917] master zone record parser currently contains unimplemented! these should be removed #567

Closed
opened 2026-03-15 23:11:56 +03:00 by kerem · 2 comments
Owner

Originally created by @bluejekyll on GitHub (Nov 10, 2019).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/917

Describe the bug

Will cause ugly failures on named startup.

see master.rs, crates/client/src/serialize/txt/rdata_parsers/null.rs, crates/server/src/store/forwarder/authority.rs

Originally created by @bluejekyll on GitHub (Nov 10, 2019). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/917 **Describe the bug** Will cause ugly failures on named startup. see `master.rs`, `crates/client/src/serialize/txt/rdata_parsers/null.rs`, `crates/server/src/store/forwarder/authority.rs`
kerem 2026-03-15 23:11:56 +03:00
Author
Owner

@koenw commented on GitHub (Sep 28, 2020):

I believe this issue can be closed. The named files don't contain unimplemented! (anymore), and the only unimplemented! I could find in the project has nothing to do with parsing.

<!-- gh-comment-id:700071711 --> @koenw commented on GitHub (Sep 28, 2020): I believe this issue can be closed. The named files don't contain `unimplemented!` (anymore), and the only `unimplemented!` I could find in the project has nothing to do with parsing.
Author
Owner

@bluejekyll commented on GitHub (Sep 28, 2020):

Thanks for reviewing that!

<!-- gh-comment-id:700184619 --> @bluejekyll commented on GitHub (Sep 28, 2020): Thanks for reviewing that!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#567
No description provided.