[GH-ISSUE #916] ResponseCode::from(u16) needs an Unknown or should be TryFrom #565

New issue

Closed

opened 2026-03-15 23:11:30 +03:00 by kerem · 2 comments

kerem commented

2026-03-15 23:11:30 +03:00

Owner

Originally created by @bluejekyll on GitHub (Nov 10, 2019).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/916

Describe the bug

This will blow up on bad input u16 data, an unimplemented!() is currently in place. We should decide if this should return ResponseCode::Unknown, or return an error.

Currently no known issues, but this could be exploited for a DOS.

Originally created by @bluejekyll on GitHub (Nov 10, 2019). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/916 **Describe the bug** This will blow up on bad input u16 data, an `unimplemented!()` is currently in place. We should decide if this should return ResponseCode::Unknown, or return an error. Currently no known issues, but this could be exploited for a DOS.

kerem

2026-03-15 23:11:30 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-15 23:11:46 +03:00

Author

Owner

@jonasbb commented on GitHub (Sep 15, 2020):

This seems to be fixed with d4da43d (#967).

@jonasbb commented on GitHub (Sep 15, 2020): This seems to be fixed with [`d4da43d` (#967)](https://github.com/bluejekyll/trust-dns/pull/967/commits/d4da43d828ce7df8e15842c7050536a641f0f653).

kerem commented

2026-03-15 23:11:51 +03:00

Author

Owner

@bluejekyll commented on GitHub (Sep 15, 2020):

I agree. Thanks for digging through that.

@bluejekyll commented on GitHub (Sep 15, 2020): I agree. Thanks for digging through that.

kerem referenced this issue

2026-03-16 02:10:33 +03:00

[PR #565] [CLOSED] Update tokio-rustls requirement from ^0.7 to ^0.8 #1512