[GH-ISSUE #488] Add more comprehensive tests for negative response caching #499

Open
opened 2026-03-15 22:49:38 +03:00 by kerem · 1 comment
Owner

Originally created by @briansmith on GitHub (May 24, 2018).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/488

Let's make sure we have test cases for the various scenarios described in the RFCs (https://tools.ietf.org/html/rfc2308 and various updates; see also https://tools.ietf.org/html/rfc1912#section-2.2). In particular, @bluejekyll noted:

The LookupState::handle_nxdomain handles searching for this, but only if the upstream server/Resolver is properly sending the SOA record.

In general, most products probably want to err on the side of querying too frequently instead of less frequently, when there's no indication of how long to cache a negative response.

Originally created by @briansmith on GitHub (May 24, 2018). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/488 Let's make sure we have test cases for the various scenarios described in the RFCs (https://tools.ietf.org/html/rfc2308 and various updates; see also https://tools.ietf.org/html/rfc1912#section-2.2). In particular, @bluejekyll noted: > The LookupState::handle_nxdomain handles searching for this, but only if the upstream server/Resolver is properly sending the SOA record. In general, most products probably want to err on the side of querying too frequently instead of less frequently, when there's no indication of how long to cache a negative response.
Author
Owner

@briansmith commented on GitHub (May 24, 2018):

@bluejekyll also suggested:

We can file an issue for adding a heuristic that would start with the minimum and then increase to either the max or SOA setting on successive failure. That’s not something needed in this change though.

That sounds like a good idea. we could start at the minimum TTL and then double to the maximum, or something. Maybe we should probably validate that that behavior is wanted by multiple things before we bother adding that complexity.

<!-- gh-comment-id:391868455 --> @briansmith commented on GitHub (May 24, 2018): @bluejekyll also suggested: > We can file an issue for adding a heuristic that would start with the minimum and then increase to either the max or SOA setting on successive failure. That’s not something needed in this change though. That sounds like a good idea. we could start at the minimum TTL and then double to the maximum, or something. Maybe we should probably validate that that behavior is wanted by multiple things before we bother adding that complexity.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#499
No description provided.