[GH-ISSUE #92] Cleaner header construction with the field_init_shorthand feature #48

New issue

Closed

opened 2026-03-07 22:18:19 +03:00 by kerem · 5 comments

kerem commented

2026-03-07 22:18:19 +03:00

Owner

Originally created by @Kerollmops on GitHub (Feb 17, 2017).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/92

github.com/bluejekyll/trust-dns@2b705dc300/client/src/op/header.rs (L289-L298)

The field_init_shorthand unstable feature can probably help you get a cleaner header construction.

Originally created by @Kerollmops on GitHub (Feb 17, 2017). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/92 https://github.com/bluejekyll/trust-dns/blob/2b705dc3001c369cd75446996cc10c8f673a35c1/client/src/op/header.rs#L289-L298 The [`field_init_shorthand` unstable feature](https://github.com/rust-lang/rust/issues/37340) can probably help you get a cleaner header construction.

kerem

2026-03-07 22:18:19 +03:00

closed this issue
added the
cleanup
label

kerem commented

2026-03-07 22:18:20 +03:00

Author

Owner

@Kerollmops commented on GitHub (Feb 17, 2017):

Ho ! Sorry, you want only stable Rust. We will probably wait this feature to be added into stable releases.

@Kerollmops commented on GitHub (Feb 17, 2017): Ho ! Sorry, you want only stable Rust. We will probably wait this feature to be added into stable releases.

kerem commented

2026-03-07 22:18:20 +03:00

Author

Owner

@bluejekyll commented on GitHub (Feb 17, 2017):

Yes, and that's some of my oldest Rust code. Could definitely use some touch ups...

@bluejekyll commented on GitHub (Feb 17, 2017): Yes, and that's some of my oldest Rust code. Could definitely use some touch ups...

kerem commented

2026-03-07 22:18:20 +03:00

Author

Owner

@briansmith commented on GitHub (Apr 27, 2017):

Rust 1.17 was released and it supports the field init shortcut syntax now.

BTW, I saw the comment in the code about using the builder pattern. I agree that the current, non-builder, way is better.

@briansmith commented on GitHub (Apr 27, 2017): Rust 1.17 was released and it supports the field init shortcut syntax now. BTW, I saw the comment in the code about using the builder pattern. I agree that the current, non-builder, way is better.

kerem commented

2026-03-07 22:18:20 +03:00

Author

Owner

@bluejekyll commented on GitHub (Apr 27, 2017):

Yeah, I just saw that today. That will be really nice. If anyone wants to submit a PR for this, that would be great. Otherwise, I'll start cleaning some of this up as I come across it.

@bluejekyll commented on GitHub (Apr 27, 2017): Yeah, I just saw that today. That will be really nice. If anyone wants to submit a PR for this, that would be great. Otherwise, I'll start cleaning some of this up as I come across it.

kerem commented

2026-03-07 22:18:20 +03:00

Author

Owner

@bluejekyll commented on GitHub (Aug 24, 2017):

fixed in #179

@bluejekyll commented on GitHub (Aug 24, 2017): fixed in #179

kerem referenced this issue

2026-03-16 01:54:00 +03:00

[PR #48] [MERGED] Add an example of how to use Name::parse #1208