mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 03:05:51 +03:00
[GH-ISSUE #365] Evaluate all Vec usage and replace with SmallVec where apropriate #463
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#463
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bluejekyll on GitHub (Mar 27, 2018).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/365
Make sure to run benchmarks before and after to see if there is a difference ;)
This should reduce heap allocations throughout the various libraries.
@link2xt commented on GitHub (Nov 23, 2021):
For some reason there is also a
tinyvecdependency already.tinyvecis a safer alternative tosmallvec:https://www.reddit.com/r/rust/comments/n2429h/arrayvec_vs_smallvec_vs_tinyvec/
Which one to use depends on actual performance of course, but would be nice to choose one and have a single dependency.
@djc commented on GitHub (Nov 24, 2021):
See some discussion in https://github.com/bluejekyll/trust-dns/pull/1388.
If you want to rip out uses of smallvec in favor of tinyvec, that'd be great!
@darnuria commented on GitHub (Jun 20, 2023):
Hi @bluejekyll /@djc, have some time this end of the month if still pertinent i can try to claim the task and do something to only use
tinyvec! :)(maybe a renaming of the ticket or opening a new one if neccessary)