starred/hickory-dns

Fork 0

mirror of https://github.com/hickory-dns/hickory-dns.git synced 2026-04-25 03:05:51 +03:00

[GH-ISSUE #348] Timeouts #455

New issue

Closed

opened 2026-03-15 22:33:45 +03:00 by kerem · 5 comments

kerem commented

2026-03-15 22:33:45 +03:00

Owner

Originally created by @DemiMarie on GitHub (Feb 18, 2018).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/348

trust-dns should enforce timeouts on all operations. Web frameworks like Gotham and Iron manage this — trust-dns should too.

Originally created by @DemiMarie on GitHub (Feb 18, 2018). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/348 `trust-dns` should enforce timeouts on all operations. Web frameworks like Gotham and Iron manage this — `trust-dns` should too.

kerem

2026-03-15 22:33:45 +03:00

closed this issue
added the
crate:server
label

kerem commented

2026-03-15 22:34:02 +03:00

Author

Owner

@bluejekyll commented on GitHub (Feb 18, 2018):

Thank you for the report. What interfaces are you using in which this is not true? All the high-level APIs for the Client and Resolver have timeouts on all operations.

@bluejekyll commented on GitHub (Feb 18, 2018): Thank you for the report. What interfaces are you using in which this is not true? All the high-level APIs for the Client and Resolver have timeouts on all operations.

kerem commented

2026-03-15 22:34:07 +03:00

Author

Owner

@DemiMarie commented on GitHub (Feb 18, 2018):

Server. I was referring to the Server TCP Denial of Service mentioned in the README.

@DemiMarie commented on GitHub (Feb 18, 2018): Server. I was referring to the Server TCP Denial of Service mentioned in the README.

kerem commented

2026-03-15 22:34:12 +03:00

Author

Owner

@bluejekyll commented on GitHub (Feb 18, 2018):

Ah, I believe the server currently has timeouts on all inbound requests, here is TCP:

https://github.com/bluejekyll/trust-dns/blob/master/server/src/server/server_future.rs#L108-L123

and TLS:

https://github.com/bluejekyll/trust-dns/blob/master/server/src/server/server_future.rs#L191-L206

UDP doesn't have timeouts as that's fire and forget. Do you have any other areas you're concerned about?

@bluejekyll commented on GitHub (Feb 18, 2018): Ah, I believe the server currently has timeouts on all inbound requests, here is TCP: https://github.com/bluejekyll/trust-dns/blob/master/server/src/server/server_future.rs#L108-L123 and TLS: https://github.com/bluejekyll/trust-dns/blob/master/server/src/server/server_future.rs#L191-L206 UDP doesn't have timeouts as that's fire and forget. Do you have any other areas you're concerned about?

kerem commented

2026-03-15 22:34:17 +03:00

Author

Owner

@bluejekyll commented on GitHub (Feb 18, 2018):

BTW, that DOS comment in the Readme is specifically about AXFR operations. I don't have the authorization logic tied to the authentication, at the moment, which is both a potential DOS because of the potential message sizes in AXFR and then also a visibility issue.

@bluejekyll commented on GitHub (Feb 18, 2018): BTW, that DOS comment in the Readme is specifically about AXFR operations. I don't have the authorization logic tied to the authentication, at the moment, which is both a potential DOS because of the potential message sizes in AXFR and then also a visibility issue.

kerem commented

2026-03-15 22:34:22 +03:00

Author

Owner

@bluejekyll commented on GitHub (Mar 5, 2018):

I'm going to close this, unless there is something more that you want to see here.

@bluejekyll commented on GitHub (Mar 5, 2018): I'm going to close this, unless there is something more that you want to see here.

kerem referenced this issue

2026-03-15 22:46:20 +03:00

[GH-ISSUE #455] Different dns lookup result for same host #491