mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-24 18:55:55 +03:00
[GH-ISSUE #346] Validate all incoming data before caching or forwarding it #452
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#452
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DemiMarie on GitHub (Feb 18, 2018).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/346
trust-dns should validate all incoming data before caching or forwarding it. That means:
Furthermore, trust-dns should drop all non-conforming input, and ensure that all output is conforming. This helps prevent attacks as CVE-2015-7547 (glibc getaddrinfo RCE) when trust-dns is used e.g. as the DNS server for a LAN.
@bluejekyll commented on GitHub (Feb 18, 2018):
Is it the server which is not currently doing this? I believe both the client and resolver meet all of these requirements.
I haven't yet built any forwarding features into the server, yet.
@DemiMarie commented on GitHub (Feb 18, 2018):
This (along with the other two issues I just raised) are more abstract principles, but yes I was referring to the Server. I was hoping that trust-dns could be used as a replacement for the insecure BIND and for djbdns, which is very secure (only one vulnerability ever discovered, and that only affected 32-bit systems), but is unmaintained (requiring 3rd party patches to support IPv6 and DNSSEC). Furthermore, I hope that trust-dns could be used as a forwarding server that essentially functions as a DNS firewall, protecting less secure systems. For example, the aforementioned glibc bug could only be exploited by malformed records, if I understand correctly.
To be clear, this involves more than what most DNS servers do; those would not have protected against the glibc bug.
@bluejekyll commented on GitHub (Feb 18, 2018):
Yes, this is a goal of mine as well. I have plans to build forwarding features into the Server, by way of incorporating the Resolver. I haven't started on that work. As an authority though, I think it meets the goals listed above.
The Resolver also implements all of those, so once forwarding is implemented, then a forwarding server should meet all of these requirements.