mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 03:05:51 +03:00
[GH-ISSUE #340] Panic with "can not lookup IPs for no names" #451
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#451
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fafhrd91 on GitHub (Feb 9, 2018).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/340
trust-dns-resolver panic 0.8, worked with 0.7
panics only on windows, works fine for unixes.
backtrace:
https://ci.appveyor.com/project/fafhrd91/actix-n9e64/build/1.0.242/job/4eqb35vu3ipq3dn0
@bluejekyll commented on GitHub (Feb 9, 2018):
Do you have the query parameters for
trust_dns_resolver::resolver_future::ResolverFuture::lookup_ip?@fafhrd91 commented on GitHub (Feb 9, 2018):
it is "localhost"
@bluejekyll commented on GitHub (Feb 10, 2018):
It looks like your test is on 32bit, correct? Do you know if the same issue is happening on 64bit?
@fafhrd91 commented on GitHub (Feb 10, 2018):
same happen on all windows related tests, 32/64bit gnu/msvc
@bluejekyll commented on GitHub (Feb 10, 2018):
ok, I see what the issue is in the code, though I don't know why it was working before vs. now...
I think making this a FQDN by adding a final dot,
localhost., will workaround this issue. I'll try and take a look when I have a minute to understand why there was a regression here and add a test case for this.@fafhrd91 commented on GitHub (Feb 10, 2018):
thanks
@bluejekyll commented on GitHub (Feb 10, 2018):
This affects all platforms in my tests, FYI. Patch coming.