[GH-ISSUE #266] Enable IPv6-specific tests by default, disable explicitly when running on Travis CI #425

Open
opened 2026-03-15 22:26:45 +03:00 by kerem · 2 comments
Owner

Originally created by @briansmith on GitHub (Oct 25, 2017).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/266

Currently many IPv6-related tests are disabled because Travis CI doesn't support IPv6 (see https://github.com/travis-ci/travis-ci/issues/5200 and related issues in their issue tracker). However, it should be made possible to enable IPv6 testing, and it should be enabled by default. Only on Travis CI should we disable IPv6 testing.

Search for // ignored until Travis-CI fixes IPv6 to find the relevant tests.

I suggest that we have a "disable-ipv6-tests" feature that, when enabled, disables the tests. I know that's not how features are supposed to work, but that's really the better semantics for this workaround. However, I'm not wedded to doing things this way; we can do things the recommended way (have a "ipv6-tests" default feature) if people prefer.

Originally created by @briansmith on GitHub (Oct 25, 2017). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/266 Currently many IPv6-related tests are disabled because Travis CI doesn't support IPv6 (see https://github.com/travis-ci/travis-ci/issues/5200 and related issues in their issue tracker). However, it should be made possible to enable IPv6 testing, and it should be enabled by default. Only on Travis CI should we disable IPv6 testing. Search for `// ignored until Travis-CI fixes IPv6` to find the relevant tests. I suggest that we have a "disable-ipv6-tests" feature that, when enabled, disables the tests. I know that's not how features are supposed to work, but that's really the better semantics for this workaround. However, I'm not wedded to doing things this way; we can do things the recommended way (have a "ipv6-tests" default feature) if people prefer.
Author
Owner

@bluejekyll commented on GitHub (Oct 25, 2017):

btw, if I remember correctly, this may only be ipv6 bound local addresses, ipv6 local -> ipv6 local trust-dns server, and ipv6 local -> ipv6 remote.

IPv6 lookups, are currently enabled by default.

<!-- gh-comment-id:339388262 --> @bluejekyll commented on GitHub (Oct 25, 2017): btw, if I remember correctly, this may only be ipv6 bound local addresses, ipv6 local -> ipv6 local trust-dns server, and ipv6 local -> ipv6 remote. IPv6 lookups, are currently enabled by default.
Author
Owner

@bluejekyll commented on GitHub (Apr 20, 2021):

Travis is no longer in use, we should review if ipv6 tests are enabled on github actions.

<!-- gh-comment-id:822884964 --> @bluejekyll commented on GitHub (Apr 20, 2021): Travis is no longer in use, we should review if ipv6 tests are enabled on github actions.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#425
No description provided.