mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 03:05:51 +03:00
[GH-ISSUE #266] Enable IPv6-specific tests by default, disable explicitly when running on Travis CI #425
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#425
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @briansmith on GitHub (Oct 25, 2017).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/266
Currently many IPv6-related tests are disabled because Travis CI doesn't support IPv6 (see https://github.com/travis-ci/travis-ci/issues/5200 and related issues in their issue tracker). However, it should be made possible to enable IPv6 testing, and it should be enabled by default. Only on Travis CI should we disable IPv6 testing.
Search for
// ignored until Travis-CI fixes IPv6to find the relevant tests.I suggest that we have a "disable-ipv6-tests" feature that, when enabled, disables the tests. I know that's not how features are supposed to work, but that's really the better semantics for this workaround. However, I'm not wedded to doing things this way; we can do things the recommended way (have a "ipv6-tests" default feature) if people prefer.
@bluejekyll commented on GitHub (Oct 25, 2017):
btw, if I remember correctly, this may only be ipv6 bound local addresses, ipv6 local -> ipv6 local trust-dns server, and ipv6 local -> ipv6 remote.
IPv6 lookups, are currently enabled by default.
@bluejekyll commented on GitHub (Apr 20, 2021):
Travis is no longer in use, we should review if ipv6 tests are enabled on github actions.