[PR #3479] [MERGED] Add handling for the case where a name exists under a delegation to other nameservers. #3877

New issue

Closed

opened 2026-03-16 12:07:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:07:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3479
Author: @xi0
Created: 3/4/2026
Status: ✅ Merged
Merged: 3/9/2026
Merged by: @djc

Base: main ← Head: fix-authoritative-referrals

📝 Commits (1)

c7989e0 Add handling for the case where a name exists under a delegation to other nameservers.

📊 Changes

3 files changed (+159 additions, -21 deletions)

View changed files

📝 crates/server/src/store/in_memory/inner.rs (+90 -0)
📝 crates/server/src/zone_handler/catalog.rs (+69 -20)
📝 tests/integration-tests/tests/integration/rfc4592_tests.rs (+0 -1)

📄 Description

This change adds handling for the case where a name exists under a delegation to other nameservers.

If NS records exist that point a subdomain elsewhere, these are returned in the AUTHORITATIVE section of the DNS response.

I have added unit tests to prevent regressions and enabled an existsing test that was previously ignored due to the broken behaviour.

This might only be a partial fix to #2810 as I have not looked at other stores than the in-memory one.

Both Rust and the hickory-dns codebase are new to me. Please let me know if something is done the wrong way.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3479 **Author:** [@xi0](https://github.com/xi0) **Created:** 3/4/2026 **Status:** ✅ Merged **Merged:** 3/9/2026 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `fix-authoritative-referrals` --- ### 📝 Commits (1) - [`c7989e0`](https://github.com/hickory-dns/hickory-dns/commit/c7989e053c9eaa072420be4aa8f7c58ca83c7f58) Add handling for the case where a name exists under a delegation to other nameservers. ### 📊 Changes **3 files changed** (+159 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/store/in_memory/inner.rs` (+90 -0) 📝 `crates/server/src/zone_handler/catalog.rs` (+69 -20) 📝 `tests/integration-tests/tests/integration/rfc4592_tests.rs` (+0 -1) </details> ### 📄 Description This change adds handling for the case where a name exists under a delegation to other nameservers. If NS records exist that point a subdomain elsewhere, these are returned in the AUTHORITATIVE section of the DNS response. I have added unit tests to prevent regressions and enabled an existsing test that was previously ignored due to the broken behaviour. This might only be a partial fix to #2810 as I have not looked at other stores than the in-memory one. Both Rust and the hickory-dns codebase are new to me. Please let me know if something is done the wrong way. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>