[PR #3463] [MERGED] chore: hickory-net does not need once_cell dep #3867

New issue

Closed

opened 2026-03-16 12:07:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:07:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3463
Author: @tisonkun
Created: 2/15/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @djc

Base: main ← Head: no-need-once-cell

📝 Commits (1)

c3b3df9 chore: hickory-net does not need once_cell dep

📊 Changes

4 files changed (+10 additions, -13 deletions)

View changed files

📝 Cargo.lock (+0 -1)
📝 conformance/Cargo.lock (+0 -1)
📝 crates/net/Cargo.toml (+0 -1)
📝 crates/net/src/multicast/mdns_stream.rs (+10 -10)

📄 Description

hickory-proto may still need once_cell since the no_std critical_section based impl depends on it and the std::sync::LazyLock is unavailable in that case.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3463 **Author:** [@tisonkun](https://github.com/tisonkun) **Created:** 2/15/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `no-need-once-cell` --- ### 📝 Commits (1) - [`c3b3df9`](https://github.com/hickory-dns/hickory-dns/commit/c3b3df96e2c072d822c9333c6322d70a075a19cf) chore: hickory-net does not need once_cell dep ### 📊 Changes **4 files changed** (+10 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+0 -1) 📝 `conformance/Cargo.lock` (+0 -1) 📝 `crates/net/Cargo.toml` (+0 -1) 📝 `crates/net/src/multicast/mdns_stream.rs` (+10 -10) </details> ### 📄 Description `hickory-proto` may still need `once_cell` since the no_std `critical_section` based impl depends on it and the `std::sync::LazyLock` is unavailable in that case. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>