[PR #3439] [MERGED] server: avoid cloning SOA record for serial update #3846

New issue

Closed

opened 2026-03-16 12:05:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:05:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3439
Author: @djc
Created: 1/16/2026
Status: ✅ Merged
Merged: 1/19/2026
Merged by: @djc

Base: main ← Head: avoid-soa-clone

📝 Commits (2)

72bd1fb server: avoid cloning SOA record for serial update
41a9b15 server: reduce rightward drift by inverting condition

📊 Changes

1 file changed (+43 additions, -44 deletions)

View changed files

📝 crates/server/src/store/sqlite/mod.rs (+43 -44)

📄 Description

cc @zachsmith1 so this turned out to be fine -- just need to bind the reference from records().await.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3439 **Author:** [@djc](https://github.com/djc) **Created:** 1/16/2026 **Status:** ✅ Merged **Merged:** 1/19/2026 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `avoid-soa-clone` --- ### 📝 Commits (2) - [`72bd1fb`](https://github.com/hickory-dns/hickory-dns/commit/72bd1fb9cf50292c755697dfd9cc0319ef08ebbc) server: avoid cloning SOA record for serial update - [`41a9b15`](https://github.com/hickory-dns/hickory-dns/commit/41a9b15fdd268dbbeacd007a6a19cd28d84ce1cc) server: reduce rightward drift by inverting condition ### 📊 Changes **1 file changed** (+43 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/store/sqlite/mod.rs` (+43 -44) </details> ### 📄 Description cc @zachsmith1 so this turned out to be fine -- just need to bind the reference from `records().await`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>