[PR #3436] [MERGED] server/sqlite: persist SOA serial bump to journal #3842

New issue

Closed

opened 2026-03-16 12:05:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:05:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3436
Author: @zachsmith1
Created: 1/14/2026
Status: ✅ Merged
Merged: 1/15/2026
Merged by: @djc

Base: main ← Head: fix/sqlitesoabump

📝 Commits (1)

1a39a01 server/sqlite: persist SOA serial bump to journal

📊 Changes

1 file changed (+124 additions, -4 deletions)

View changed files

📝 crates/server/src/store/sqlite/mod.rs (+124 -4)

📄 Description

Summary

Persist the post-update SOA record (including the incremented serial) to the SQLite journal after successful RFC2136 updates.
Add a regression test that ensures SOA serial remains monotonic across journal recovery (restart).

Test plan

cargo test --workspace --all-features

Fixes: https://github.com/hickory-dns/hickory-dns/issues/3429

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3436 **Author:** [@zachsmith1](https://github.com/zachsmith1) **Created:** 1/14/2026 **Status:** ✅ Merged **Merged:** 1/15/2026 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `fix/sqlitesoabump` --- ### 📝 Commits (1) - [`1a39a01`](https://github.com/hickory-dns/hickory-dns/commit/1a39a01afcd54a7792d591590791391e62bc3b95) server/sqlite: persist SOA serial bump to journal ### 📊 Changes **1 file changed** (+124 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/store/sqlite/mod.rs` (+124 -4) </details> ### 📄 Description ## Summary - Persist the post-update SOA record (including the incremented serial) to the SQLite journal after successful RFC2136 updates. - Add a regression test that ensures SOA serial remains monotonic across journal recovery (restart). ## Test plan - [x] `cargo test --workspace --all-features` Fixes: https://github.com/hickory-dns/hickory-dns/issues/3429 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>