[PR #3421] [MERGED] Minor metrics tidying #3834

New issue

Closed

opened 2026-03-16 12:05:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:05:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3421
Author: @cpu
Created: 12/31/2025
Status: ✅ Merged
Merged: 1/2/2026
Merged by: @cpu

Base: main ← Head: cpu-histos_dev

📝 Commits (4)

5e19399 bin: avoid blocklist helper in opp enc named_metrics_tests
26c8770 test-support: add metrics test helpers
1eb43b7 bin: fix unused import warn in integration tests
2ec0d8a bin: feature guard named_rfc_9539_tests

📊 Changes

7 files changed (+199 additions, -106 deletions)

View changed files

📝 Cargo.lock (+2 -0)
📝 bin/tests/integration/named_metrics_tests.rs (+17 -10)
📝 bin/tests/integration/named_rfc_9539_tests.rs (+2 -0)
📝 crates/resolver/src/name_server.rs (+106 -62)
📝 crates/resolver/src/recursor/tests.rs (+6 -34)
📝 tests/test-support/Cargo.toml (+2 -0)
📝 tests/test-support/src/lib.rs (+64 -0)

📄 Description

Pulling out some tidying from broader work I haven't gotten to a PR-able status quite yet.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3421 **Author:** [@cpu](https://github.com/cpu) **Created:** 12/31/2025 **Status:** ✅ Merged **Merged:** 1/2/2026 **Merged by:** [@cpu](https://github.com/cpu) **Base:** `main` ← **Head:** `cpu-histos_dev` --- ### 📝 Commits (4) - [`5e19399`](https://github.com/hickory-dns/hickory-dns/commit/5e193997507f3387dca4967e04adfdcaac1f4fe3) bin: avoid blocklist helper in opp enc named_metrics_tests - [`26c8770`](https://github.com/hickory-dns/hickory-dns/commit/26c8770a460c7e5965719fa893e28877868bb42a) test-support: add metrics test helpers - [`1eb43b7`](https://github.com/hickory-dns/hickory-dns/commit/1eb43b70ade9bdfedb67f9a8d07fd3d335522aad) bin: fix unused import warn in integration tests - [`2ec0d8a`](https://github.com/hickory-dns/hickory-dns/commit/2ec0d8a4c2abadf125d5a142841c436e884eaf6f) bin: feature guard named_rfc_9539_tests ### 📊 Changes **7 files changed** (+199 additions, -106 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+2 -0) 📝 `bin/tests/integration/named_metrics_tests.rs` (+17 -10) 📝 `bin/tests/integration/named_rfc_9539_tests.rs` (+2 -0) 📝 `crates/resolver/src/name_server.rs` (+106 -62) 📝 `crates/resolver/src/recursor/tests.rs` (+6 -34) 📝 `tests/test-support/Cargo.toml` (+2 -0) 📝 `tests/test-support/src/lib.rs` (+64 -0) </details> ### 📄 Description Pulling out some tidying from broader work I haven't gotten to a PR-able status quite yet. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>