[PR #3413] resolver: replace ipconfig with direct windows-sys bindings #3822

New issue

Open

opened 2026-03-16 12:04:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:04:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3413
Author: @djc
Created: 12/19/2025
Status: 🔄 Open

Base: main ← Head: windows-config

📝 Commits (1)

49d353b resolver: replace ipconfig with direct windows-sys bindings

📊 Changes

4 files changed (+125 additions, -142 deletions)

View changed files

📝 Cargo.lock (+20 -112)
📝 Cargo.toml (+2 -1)
📝 crates/resolver/Cargo.toml (+3 -2)
📝 crates/resolver/src/system_conf/windows.rs (+100 -27)

📄 Description

This replaces the resolver's dependency on the ipconfig crate with inlined bindings, which I've written by looking at the code from ipconfig and modernizing it/simplifying it just for our needs. The ipconfig crate:

Hasn't released in 2.5 years
As a result of that, depends on old (large) Windows dependencies
Has a maintainer who is unresponsive in the repo and via private email

This has some unsafe code but (a) there's not a lot, and (b) I think it's mostly not that scary.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3413 **Author:** [@djc](https://github.com/djc) **Created:** 12/19/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `windows-config` --- ### 📝 Commits (1) - [`49d353b`](https://github.com/hickory-dns/hickory-dns/commit/49d353ba79fe0b49bed6198cfe0405917f5c0400) resolver: replace ipconfig with direct windows-sys bindings ### 📊 Changes **4 files changed** (+125 additions, -142 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+20 -112) 📝 `Cargo.toml` (+2 -1) 📝 `crates/resolver/Cargo.toml` (+3 -2) 📝 `crates/resolver/src/system_conf/windows.rs` (+100 -27) </details> ### 📄 Description This replaces the resolver's dependency on the ipconfig crate with inlined bindings, which I've written by looking at the code from ipconfig and modernizing it/simplifying it just for our needs. The ipconfig crate: - Hasn't released in 2.5 years - As a result of that, depends on old (large) Windows dependencies - Has a maintainer who is unresponsive in the repo and via private email This has some `unsafe` code but (a) there's not a lot, and (b) I think it's mostly not that scary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>