[PR #3404] [MERGED] update tests broken by example.com zone changes #3814

New issue

Closed

opened 2026-03-16 12:04:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:04:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3404
Author: @cpu
Created: 12/17/2025
Status: ✅ Merged
Merged: 12/18/2025
Merged by: @cpu

Base: main ← Head: cpu-fix-example-com-test_dev

📝 Commits (2)

f1192e1 net: update async_client expected results
3d279f9 integration-tests: switch test_nsec3_nxdomain name

📊 Changes

2 files changed (+18 additions, -10 deletions)

View changed files

📝 crates/net/src/client/tests.rs (+17 -9)
📝 tests/integration-tests/tests/integration/client_tests.rs (+1 -1)

📄 Description

Quick fixes to unblock CI, ideally these tests wouldn't rely on external hosts out of our control.

The first test async_client, needed to be updated to expect two new IP address A records in the response.

The second test test_nsec3_nxdomain needed to be changed to a different domain (iana.org vs example.com), because the latter switched away from NSEC3:

Compare:

$ dig @8.8.8.8 +dnssec a.b.c.example.com NS

; <<>> DiG 9.20.15 <<>> @8.8.8.8 +dnssec a.b.c.example.com NS
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 64782
;; flags: qr rd ra ad; QUERY: 1, ANSWER: 0, AUTHORITY: 4, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags: do; udp: 512
;; QUESTION SECTION:
;a.b.c.example.com.		IN	NS

;; AUTHORITY SECTION:
example.com.		1464	IN	SOA	elliott.ns.cloudflare.com. dns.cloudflare.com. 2391407559 10000 2400 604800 1800
a.b.c.example.com.	1464	IN	NSEC	\000.a.b.c.example.com. RRSIG NSEC TYPE128
example.com.		1464	IN	RRSIG	SOA 13 2 1800 20251219155244 20251217135244 34505 example.com. LP/rWY3C/Vg14ldvxOMPh1DO1RDkv/MmrQUSEG8UxaK1sasZtssmruGu VWdk81hUh6mqlriF7IJ1s3xgVsFAJA==
a.b.c.example.com.	1464	IN	RRSIG	NSEC 13 5 1800 20251219155244 20251217135244 34505 example.com. /40F7chZk4H3pAa2O1B5ePIiuaUhiSlHLMt/6k3NiVe2madPZvKHgNHZ BMNCBl2f+wpxOVsN9lPxNThyG9RxVQ==

;; Query time: 11 msec
;; SERVER: 8.8.8.8#53(8.8.8.8) (UDP)
;; WHEN: Thu Dec 18 09:58:20 EST 2025
;; MSG SIZE  rcvd: 374

$ dig @8.8.8.8 +dnssec a.b.c.iana.org NS

; <<>> DiG 9.20.15 <<>> @8.8.8.8 +dnssec a.b.c.iana.org NS
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id: 48556
;; flags: qr rd ra ad; QUERY: 1, ANSWER: 0, AUTHORITY: 8, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags: do; udp: 512
;; QUESTION SECTION:
;a.b.c.iana.org.			IN	NS

;; AUTHORITY SECTION:
idq6oooh0kl4e5936999ioifr965sik2.iana.org. 3600	IN NSEC3 1 0 0 - J3J9PC7HR4KSMGK9Q14BKHDD9OL5RPK7 CNAME RRSIG
idq6oooh0kl4e5936999ioifr965sik2.iana.org. 3600	IN RRSIG NSEC3 13 3 3600 20251229234533 20251208143420 18022 iana.org. 2JQC1kxQeTZIZZHIzeU333LvT9EaPU8VpwS4ccWTZ7IROZEvdNMpnTFX 4y/ji2ouQ+PUu4z1rH/NNwYRgd32Rw==
mvnqhoigoa305s1i78hp6cdv5n7lcutc.iana.org. 3600	IN NSEC3 1 0 0 - NGJOKE6KAKN5BC83M0IAPQVRBAJKQI3M A NS SOA MX TXT AAAA RRSIG DNSKEY NSEC3PARAM CAA
mvnqhoigoa305s1i78hp6cdv5n7lcutc.iana.org. 3600	IN RRSIG NSEC3 13 3 3600 20251230011729 20251208143420 18022 iana.org. OFefF4snc7algtZ3HNiKfW9+EFAIzVf4C0nK7pUP4QRIWYVBFiUZv75P ogeUM72xSpx4hzxhTIGlOEg0cMU2eQ==
0d5cbi611aogl6kk8jjsopfic6dcb42t.iana.org. 3600	IN NSEC3 1 0 0 - 26CS5JG5RASD1SS5VNTJ9PSC7FDVQIEO CNAME RRSIG
0d5cbi611aogl6kk8jjsopfic6dcb42t.iana.org. 3600	IN RRSIG NSEC3 13 3 3600 20251230002659 20251208143420 18022 iana.org. Hps0iVVpyqBsb6r6Mb/N44H0jYzFdf8WKDaEcVfzxNXo/mmc/Ufr12Mn 6xK+JEUzOEpZU7JMXefinQSKR1KNgg==
iana.org.		1800	IN	SOA	sns.dns.icann.org. noc.dns.icann.org. 2025121107 7200 3600 1209600 3600
iana.org.		1800	IN	RRSIG	SOA 13 2 3600 20260107201848 20251218064036 7682 iana.org. T/DZP2ummjOrpEzOdOM9Mp9vcpDgpl1H+I5qR4/G47k6PHxIaO4Upljx SiR6+WD2MVxBC3pHYYqvzlrhlltcog==

;; Query time: 84 msec
;; SERVER: 8.8.8.8#53(8.8.8.8) (UDP)
;; WHEN: Thu Dec 18 09:58:31 EST 2025
;; MSG SIZE  rcvd: 754

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3404 **Author:** [@cpu](https://github.com/cpu) **Created:** 12/17/2025 **Status:** ✅ Merged **Merged:** 12/18/2025 **Merged by:** [@cpu](https://github.com/cpu) **Base:** `main` ← **Head:** `cpu-fix-example-com-test_dev` --- ### 📝 Commits (2) - [`f1192e1`](https://github.com/hickory-dns/hickory-dns/commit/f1192e146c73dd21317ce63a8c56b3ad584c89c7) net: update async_client expected results - [`3d279f9`](https://github.com/hickory-dns/hickory-dns/commit/3d279f935362e4208230234848945ec29a3a0c8a) integration-tests: switch test_nsec3_nxdomain name ### 📊 Changes **2 files changed** (+18 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `crates/net/src/client/tests.rs` (+17 -9) 📝 `tests/integration-tests/tests/integration/client_tests.rs` (+1 -1) </details> ### 📄 Description Quick fixes to unblock CI, ideally these tests wouldn't rely on external hosts out of our control. The first test `async_client`, needed to be updated to expect two new IP address A records in the response. The second test `test_nsec3_nxdomain` needed to be changed to a different domain (`iana.org` vs `example.com`), because the latter switched away from NSEC3: Compare: ``` $ dig @8.8.8.8 +dnssec a.b.c.example.com NS ; <<>> DiG 9.20.15 <<>> @8.8.8.8 +dnssec a.b.c.example.com NS ; (1 server found) ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 64782 ;; flags: qr rd ra ad; QUERY: 1, ANSWER: 0, AUTHORITY: 4, ADDITIONAL: 1 ;; OPT PSEUDOSECTION: ; EDNS: version: 0, flags: do; udp: 512 ;; QUESTION SECTION: ;a.b.c.example.com. IN NS ;; AUTHORITY SECTION: example.com. 1464 IN SOA elliott.ns.cloudflare.com. dns.cloudflare.com. 2391407559 10000 2400 604800 1800 a.b.c.example.com. 1464 IN NSEC \000.a.b.c.example.com. RRSIG NSEC TYPE128 example.com. 1464 IN RRSIG SOA 13 2 1800 20251219155244 20251217135244 34505 example.com. LP/rWY3C/Vg14ldvxOMPh1DO1RDkv/MmrQUSEG8UxaK1sasZtssmruGu VWdk81hUh6mqlriF7IJ1s3xgVsFAJA== a.b.c.example.com. 1464 IN RRSIG NSEC 13 5 1800 20251219155244 20251217135244 34505 example.com. /40F7chZk4H3pAa2O1B5ePIiuaUhiSlHLMt/6k3NiVe2madPZvKHgNHZ BMNCBl2f+wpxOVsN9lPxNThyG9RxVQ== ;; Query time: 11 msec ;; SERVER: 8.8.8.8#53(8.8.8.8) (UDP) ;; WHEN: Thu Dec 18 09:58:20 EST 2025 ;; MSG SIZE rcvd: 374 ``` vs ``` $ dig @8.8.8.8 +dnssec a.b.c.iana.org NS ; <<>> DiG 9.20.15 <<>> @8.8.8.8 +dnssec a.b.c.iana.org NS ; (1 server found) ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id: 48556 ;; flags: qr rd ra ad; QUERY: 1, ANSWER: 0, AUTHORITY: 8, ADDITIONAL: 1 ;; OPT PSEUDOSECTION: ; EDNS: version: 0, flags: do; udp: 512 ;; QUESTION SECTION: ;a.b.c.iana.org. IN NS ;; AUTHORITY SECTION: idq6oooh0kl4e5936999ioifr965sik2.iana.org. 3600 IN NSEC3 1 0 0 - J3J9PC7HR4KSMGK9Q14BKHDD9OL5RPK7 CNAME RRSIG idq6oooh0kl4e5936999ioifr965sik2.iana.org. 3600 IN RRSIG NSEC3 13 3 3600 20251229234533 20251208143420 18022 iana.org. 2JQC1kxQeTZIZZHIzeU333LvT9EaPU8VpwS4ccWTZ7IROZEvdNMpnTFX 4y/ji2ouQ+PUu4z1rH/NNwYRgd32Rw== mvnqhoigoa305s1i78hp6cdv5n7lcutc.iana.org. 3600 IN NSEC3 1 0 0 - NGJOKE6KAKN5BC83M0IAPQVRBAJKQI3M A NS SOA MX TXT AAAA RRSIG DNSKEY NSEC3PARAM CAA mvnqhoigoa305s1i78hp6cdv5n7lcutc.iana.org. 3600 IN RRSIG NSEC3 13 3 3600 20251230011729 20251208143420 18022 iana.org. OFefF4snc7algtZ3HNiKfW9+EFAIzVf4C0nK7pUP4QRIWYVBFiUZv75P ogeUM72xSpx4hzxhTIGlOEg0cMU2eQ== 0d5cbi611aogl6kk8jjsopfic6dcb42t.iana.org. 3600 IN NSEC3 1 0 0 - 26CS5JG5RASD1SS5VNTJ9PSC7FDVQIEO CNAME RRSIG 0d5cbi611aogl6kk8jjsopfic6dcb42t.iana.org. 3600 IN RRSIG NSEC3 13 3 3600 20251230002659 20251208143420 18022 iana.org. Hps0iVVpyqBsb6r6Mb/N44H0jYzFdf8WKDaEcVfzxNXo/mmc/Ufr12Mn 6xK+JEUzOEpZU7JMXefinQSKR1KNgg== iana.org. 1800 IN SOA sns.dns.icann.org. noc.dns.icann.org. 2025121107 7200 3600 1209600 3600 iana.org. 1800 IN RRSIG SOA 13 2 3600 20260107201848 20251218064036 7682 iana.org. T/DZP2ummjOrpEzOdOM9Mp9vcpDgpl1H+I5qR4/G47k6PHxIaO4Upljx SiR6+WD2MVxBC3pHYYqvzlrhlltcog== ;; Query time: 84 msec ;; SERVER: 8.8.8.8#53(8.8.8.8) (UDP) ;; WHEN: Thu Dec 18 09:58:31 EST 2025 ;; MSG SIZE rcvd: 754 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>