[PR #3400] [MERGED] Lookup message tweaks #3813

New issue

Closed

opened 2026-03-16 12:04:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:04:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3400
Author: @djc
Created: 12/15/2025
Status: ✅ Merged
Merged: 12/16/2025
Merged by: @djc

Base: main ← Head: lookup-message-tweaks

📝 Commits (10+)

c0ceeb7 proto: simplify DNSSEC iterator setup
fee2d0f resolver: drop untested niche platform configuration
1b2a539 resolver: drop simplify runtime provider abstraction
187e1b0 resolver: wrap example test in a tests module
6281660 resolver: drop unnecessary Arc wrapping in example
78ae3bb resolver: further simplify example code
e0926b3 resolver: keep condition setup closer to usage
b9a7d7d resolver: avoid short-lived allocations
12e70aa resolver: avoid cloning when discarding original message
b5e64c2 resolver: avoid unnecessary boxing

📊 Changes

14 files changed (+249 additions, -307 deletions)

View changed files

📝 crates/proto/src/dnssec/mod.rs (+4 -22)
📝 crates/proto/src/dnssec/rdata/tsig.rs (+8 -3)
📝 crates/proto/src/dnssec/signer.rs (+1 -1)
📝 crates/proto/src/dnssec/tsig.rs (+10 -7)
📝 crates/proto/src/op/message.rs (+35 -17)
📝 crates/resolver/examples/flush_cache.rs (+22 -48)
📝 crates/resolver/src/caching_client.rs (+80 -101)
📝 crates/resolver/src/hosts.rs (+38 -38)
📝 crates/resolver/src/lookup.rs (+31 -31)
📝 crates/resolver/src/lookup_ip.rs (+5 -8)
📝 crates/resolver/src/resolver.rs (+4 -3)
📝 crates/server/src/store/blocklist.rs (+1 -1)
📝 crates/server/src/zone_handler/catalog.rs (+9 -26)
📝 tests/integration-tests/tests/integration/lookup_tests.rs (+1 -1)

📄 Description

Followup from

#3310

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3400 **Author:** [@djc](https://github.com/djc) **Created:** 12/15/2025 **Status:** ✅ Merged **Merged:** 12/16/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `lookup-message-tweaks` --- ### 📝 Commits (10+) - [`c0ceeb7`](https://github.com/hickory-dns/hickory-dns/commit/c0ceeb7821364302d50c07359b82497590eaffc4) proto: simplify DNSSEC iterator setup - [`fee2d0f`](https://github.com/hickory-dns/hickory-dns/commit/fee2d0f5127649f5e4da1d6e1dcf5a383ec35521) resolver: drop untested niche platform configuration - [`1b2a539`](https://github.com/hickory-dns/hickory-dns/commit/1b2a539e52e55b83feaf3afc55e1bec64d3a5ff6) resolver: drop simplify runtime provider abstraction - [`187e1b0`](https://github.com/hickory-dns/hickory-dns/commit/187e1b0dc674548000d491a4fb3af81fe8964242) resolver: wrap example test in a tests module - [`6281660`](https://github.com/hickory-dns/hickory-dns/commit/6281660676e87da1946f9be0b145eede2e268373) resolver: drop unnecessary Arc wrapping in example - [`78ae3bb`](https://github.com/hickory-dns/hickory-dns/commit/78ae3bb4fbf440ff1adc5eac8509d5748e0de4da) resolver: further simplify example code - [`e0926b3`](https://github.com/hickory-dns/hickory-dns/commit/e0926b3fa5bf96d38c3976f669a88011b9fff6ad) resolver: keep condition setup closer to usage - [`b9a7d7d`](https://github.com/hickory-dns/hickory-dns/commit/b9a7d7d3708d6b992f4c6b09290cd9434ac5833f) resolver: avoid short-lived allocations - [`12e70aa`](https://github.com/hickory-dns/hickory-dns/commit/12e70aa818fe8a98eef654b1c57121ede5825d5d) resolver: avoid cloning when discarding original message - [`b5e64c2`](https://github.com/hickory-dns/hickory-dns/commit/b5e64c2d637dda5d7282833dc6f622f02d8af9c3) resolver: avoid unnecessary boxing ### 📊 Changes **14 files changed** (+249 additions, -307 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/mod.rs` (+4 -22) 📝 `crates/proto/src/dnssec/rdata/tsig.rs` (+8 -3) 📝 `crates/proto/src/dnssec/signer.rs` (+1 -1) 📝 `crates/proto/src/dnssec/tsig.rs` (+10 -7) 📝 `crates/proto/src/op/message.rs` (+35 -17) 📝 `crates/resolver/examples/flush_cache.rs` (+22 -48) 📝 `crates/resolver/src/caching_client.rs` (+80 -101) 📝 `crates/resolver/src/hosts.rs` (+38 -38) 📝 `crates/resolver/src/lookup.rs` (+31 -31) 📝 `crates/resolver/src/lookup_ip.rs` (+5 -8) 📝 `crates/resolver/src/resolver.rs` (+4 -3) 📝 `crates/server/src/store/blocklist.rs` (+1 -1) 📝 `crates/server/src/zone_handler/catalog.rs` (+9 -26) 📝 `tests/integration-tests/tests/integration/lookup_tests.rs` (+1 -1) </details> ### 📄 Description Followup from - #3310 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>