[PR #3396] [MERGED] Drop explicit library target declarations #3808

Closed
opened 2026-03-16 12:03:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3396
Author: @djc
Created: 12/13/2025
Status: Merged
Merged: 12/13/2025
Merged by: @djc

Base: mainHead: drop-targets


📝 Commits (1)

  • 21b84d0 Drop explicit library target declarations

📊 Changes

5 files changed (+0 additions, -20 deletions)

View changed files

📝 crates/proto/Cargo.toml (+0 -4)
📝 crates/resolver/Cargo.toml (+0 -4)
📝 crates/server/Cargo.toml (+0 -4)
📝 tests/compatibility-tests/Cargo.toml (+0 -4)
📝 tests/integration-tests/Cargo.toml (+0 -4)

📄 Description

These are unnecessary, and the duplicated name cost me a lot of time yesterday trying to debug why Cargo saw duplicate crate names.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3396 **Author:** [@djc](https://github.com/djc) **Created:** 12/13/2025 **Status:** ✅ Merged **Merged:** 12/13/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `drop-targets` --- ### 📝 Commits (1) - [`21b84d0`](https://github.com/hickory-dns/hickory-dns/commit/21b84d0e421e842091eeaae7b0d00832a8044819) Drop explicit library target declarations ### 📊 Changes **5 files changed** (+0 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/Cargo.toml` (+0 -4) 📝 `crates/resolver/Cargo.toml` (+0 -4) 📝 `crates/server/Cargo.toml` (+0 -4) 📝 `tests/compatibility-tests/Cargo.toml` (+0 -4) 📝 `tests/integration-tests/Cargo.toml` (+0 -4) </details> ### 📄 Description These are unnecessary, and the duplicated name cost me a lot of time yesterday trying to debug why Cargo saw duplicate crate names. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 12:03:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3808
No description provided.