[PR #3391] [MERGED] conformance: drop superfluous unsafe tests #3801

New issue

Closed

opened 2026-03-16 12:03:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:03:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3391
Author: @djc
Created: 12/11/2025
Status: ✅ Merged
Merged: 12/11/2025
Merged by: @cpu

Base: main ← Head: drop-set-var-tests

📝 Commits (1)

141e2fb conformance: drop superfluous unsafe tests

📊 Changes

1 file changed (+0 additions, -44 deletions)

View changed files

📝 conformance/dns-test/src/lib.rs (+0 -44)

📄 Description

These tests are effectively testing the std implementation of LazyLock, which doesn't seem particularly useful to me. But they are using env::set_var() which has somewhat complicated safety requirements. This doesn't seem worth it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3391 **Author:** [@djc](https://github.com/djc) **Created:** 12/11/2025 **Status:** ✅ Merged **Merged:** 12/11/2025 **Merged by:** [@cpu](https://github.com/cpu) **Base:** `main` ← **Head:** `drop-set-var-tests` --- ### 📝 Commits (1) - [`141e2fb`](https://github.com/hickory-dns/hickory-dns/commit/141e2fb553688d2fef3a7ece13f8ab6a19414dbd) conformance: drop superfluous unsafe tests ### 📊 Changes **1 file changed** (+0 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `conformance/dns-test/src/lib.rs` (+0 -44) </details> ### 📄 Description These tests are effectively testing the std implementation of `LazyLock`, which doesn't seem particularly useful to me. But they are using `env::set_var()` which has somewhat complicated safety requirements. This doesn't seem worth it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>