[PR #3357] [MERGED] dns-test: lock NetworkInner::new more effectively #3773

New issue

Closed

opened 2026-03-16 12:01:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:01:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3357
Author: @marcus0x62
Created: 11/21/2025
Status: ✅ Merged
Merged: 11/21/2025
Merged by: @marcus0x62

Base: main ← Head: dns-test-retry-network-creates

📝 Commits (1)

fbc2130 dns-test: lock NetworkInner::new more effectively

📊 Changes

1 file changed (+5 additions, -6 deletions)

View changed files

📝 conformance/dns-test/src/container/network.rs (+5 -6)

📄 Description

I've been having sporadic local conformance failures caused by multiple threads trying to create networks at the same time (with the same name.) dns-test included a guard around the invocation of docker network create, but that is insufficient, since the name of the test network is generated earlier in the function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3357 **Author:** [@marcus0x62](https://github.com/marcus0x62) **Created:** 11/21/2025 **Status:** ✅ Merged **Merged:** 11/21/2025 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `dns-test-retry-network-creates` --- ### 📝 Commits (1) - [`fbc2130`](https://github.com/hickory-dns/hickory-dns/commit/fbc21307e9502a7cf8c52da502a4b1607806ff77) dns-test: lock NetworkInner::new more effectively ### 📊 Changes **1 file changed** (+5 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `conformance/dns-test/src/container/network.rs` (+5 -6) </details> ### 📄 Description I've been having sporadic local conformance failures caused by multiple threads trying to create networks at the same time (with the same name.) dns-test included a guard around the invocation of docker network create, but that is insufficient, since the name of the test network is generated earlier in the function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>