[PR #3347] [MERGED] feat(proto): Add support for dynamic headers in DoH request #3763

New issue

Closed

opened 2026-03-16 12:01:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:01:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3347
Author: @lpraneis
Created: 11/10/2025
Status: ✅ Merged
Merged: 11/14/2025
Merged by: @djc

Base: main ← Head: lpraneis/dynamic-doh-headers

📝 Commits (2)

20f819d doc: Rename TlsConfig to HttpsClientConfig
4d21738 feat(proto): Add ability to specify additional dynamic headers in DoH request

📊 Changes

4 files changed (+125 additions, -19 deletions)

View changed files

📝 crates/proto/src/h2/h2_client_stream.rs (+58 -11)
📝 crates/proto/src/h2/mod.rs (+2 -1)
📝 crates/proto/src/http/request.rs (+64 -6)
📝 crates/resolver/src/connection_provider.rs (+1 -1)

📄 Description

Draft implementation of https://github.com/hickory-dns/hickory-dns/issues/3346

This PR adds the ability to add dynamic headers to a DoH request, implemented via a trait to allow callers to provide a custom implementation. This has just been added to the builder type for the HttpsClientConnect type for simplicity and small API surface changes.

I opted to use a HashMap<String,String> instead of a HeaderMap to avoid re-exporting the http::HeaderMap type but can definitely change if that's fine to re-use.

Add unit tests
Polish and add more in-depth documentation

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3347 **Author:** [@lpraneis](https://github.com/lpraneis) **Created:** 11/10/2025 **Status:** ✅ Merged **Merged:** 11/14/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `lpraneis/dynamic-doh-headers` --- ### 📝 Commits (2) - [`20f819d`](https://github.com/hickory-dns/hickory-dns/commit/20f819debdf7aa3e8cd58777947f16f8056b1563) doc: Rename TlsConfig to HttpsClientConfig - [`4d21738`](https://github.com/hickory-dns/hickory-dns/commit/4d217387cbe8856e07d17734b995cc4e5618dbca) feat(proto): Add ability to specify additional dynamic headers in DoH request ### 📊 Changes **4 files changed** (+125 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/h2/h2_client_stream.rs` (+58 -11) 📝 `crates/proto/src/h2/mod.rs` (+2 -1) 📝 `crates/proto/src/http/request.rs` (+64 -6) 📝 `crates/resolver/src/connection_provider.rs` (+1 -1) </details> ### 📄 Description Draft implementation of https://github.com/hickory-dns/hickory-dns/issues/3346 This PR adds the ability to add dynamic headers to a DoH request, implemented via a trait to allow callers to provide a custom implementation. This has just been added to the builder type for the `HttpsClientConnect` type for simplicity and small API surface changes. I opted to use a `HashMap<String,String>` instead of a `HeaderMap` to avoid re-exporting the `http::HeaderMap` type but can definitely change if that's fine to re-use. - [x] Add unit tests - [x] Polish and add more in-depth documentation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>