[PR #3337] [MERGED] Check TTL in NameServerPool cache in the recursor #3759

New issue

Closed

opened 2026-03-16 12:01:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:01:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3337
Author: @marcus0x62
Created: 10/29/2025
Status: ✅ Merged
Merged: 10/30/2025
Merged by: @marcus0x62

Base: main ← Head: ns-cache-ttl

📝 Commits (3)

9ba6be0 recursor: unit test for name server cache TTL enforcement
eb39aa9 recursor: enforce TTL in NameServerPools
a607b9a proto: fix unrelated clippy error

📊 Changes

6 files changed (+440 additions, -23 deletions)

View changed files

📝 crates/proto/src/dnssec/signer.rs (+3 -3)
📝 crates/recursor/Cargo.toml (+1 -1)
📝 crates/recursor/src/recursor_dns_handle.rs (+56 -13)
📝 crates/recursor/src/tests.rs (+340 -5)
📝 crates/resolver/src/name_server_pool.rs (+22 -0)
📝 tests/test-support/src/lib.rs (+18 -1)

📄 Description

Addresses #2574 by storing a minimum TTL (bounded by the positive min/max settings configured by the user) in the NameServerPool for a zone and checking for TTL expiration before using a cached pool entry.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3337 **Author:** [@marcus0x62](https://github.com/marcus0x62) **Created:** 10/29/2025 **Status:** ✅ Merged **Merged:** 10/30/2025 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `ns-cache-ttl` --- ### 📝 Commits (3) - [`9ba6be0`](https://github.com/hickory-dns/hickory-dns/commit/9ba6be0d59dd3f285ec1a80e469aecd02c388feb) recursor: unit test for name server cache TTL enforcement - [`eb39aa9`](https://github.com/hickory-dns/hickory-dns/commit/eb39aa97d2c5a7e7084ec54eab699cad7aa06b85) recursor: enforce TTL in NameServerPools - [`a607b9a`](https://github.com/hickory-dns/hickory-dns/commit/a607b9aef12cb2ec289636c6be035cf79dcd3965) proto: fix unrelated clippy error ### 📊 Changes **6 files changed** (+440 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/signer.rs` (+3 -3) 📝 `crates/recursor/Cargo.toml` (+1 -1) 📝 `crates/recursor/src/recursor_dns_handle.rs` (+56 -13) 📝 `crates/recursor/src/tests.rs` (+340 -5) 📝 `crates/resolver/src/name_server_pool.rs` (+22 -0) 📝 `tests/test-support/src/lib.rs` (+18 -1) </details> ### 📄 Description Addresses #2574 by storing a minimum TTL (bounded by the positive min/max settings configured by the user) in the NameServerPool for a zone and checking for TTL expiration before using a cached pool entry. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>