[PR #3339] [MERGED] proto: simplify UDP retry code #3757

New issue

Closed

opened 2026-03-16 12:01:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:01:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3339
Author: @djc
Created: 10/30/2025
Status: ✅ Merged
Merged: 10/30/2025
Merged by: @djc

Base: main ← Head: udp-send

📝 Commits (10+)

fde4a37 proto: inline send_udp_message()
6ead6e7 proto: rename closure_data to cx
a85ddab proto: move RequestContext initialization into RequestContext::new()
453a309 proto: inline values in RequestContext initialization
00ee098 proto: rename RequestContext to UdpRequest
eaeddc4 proto: avoid unnecessary Arc-wrapping
df4a07d proto: simplify UdpRequest::send() receiver type
e2dd2bd proto: move test into tests module
98ec926 proto: simplify retry interface
125cc22 proto: move UdpClientStreamBuilder below UdpClientStream

📊 Changes

1 file changed (+400 additions, -400 deletions)

View changed files

📝 crates/proto/src/udp/udp_client_stream.rs (+400 -400)

📄 Description

Ended up looking at the code from

#3311

some more, I think this makes stuff a little nicer.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3339 **Author:** [@djc](https://github.com/djc) **Created:** 10/30/2025 **Status:** ✅ Merged **Merged:** 10/30/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `udp-send` --- ### 📝 Commits (10+) - [`fde4a37`](https://github.com/hickory-dns/hickory-dns/commit/fde4a378abc9602c37d68bf4b63469b51cd684cc) proto: inline send_udp_message() - [`6ead6e7`](https://github.com/hickory-dns/hickory-dns/commit/6ead6e7307b86f6167adf73a9a26cbd6dff8a787) proto: rename closure_data to cx - [`a85ddab`](https://github.com/hickory-dns/hickory-dns/commit/a85ddab20383ca53e421b87a94d9d70bdec071f5) proto: move RequestContext initialization into RequestContext::new() - [`453a309`](https://github.com/hickory-dns/hickory-dns/commit/453a30986da306a7c2a7670f5d79738e36dc128e) proto: inline values in RequestContext initialization - [`00ee098`](https://github.com/hickory-dns/hickory-dns/commit/00ee0984da88174b3681e8e723a76a3710cb9ab3) proto: rename RequestContext to UdpRequest - [`eaeddc4`](https://github.com/hickory-dns/hickory-dns/commit/eaeddc45cb8f5f48cb4a0841587c894f773aa639) proto: avoid unnecessary Arc-wrapping - [`df4a07d`](https://github.com/hickory-dns/hickory-dns/commit/df4a07da06f96192983f0e5330a16e46beab99e5) proto: simplify UdpRequest::send() receiver type - [`e2dd2bd`](https://github.com/hickory-dns/hickory-dns/commit/e2dd2bdf0da21f887852087f50d65351e992fec5) proto: move test into tests module - [`98ec926`](https://github.com/hickory-dns/hickory-dns/commit/98ec9264f2b2f6a363879558c872f07a334f66ca) proto: simplify retry interface - [`125cc22`](https://github.com/hickory-dns/hickory-dns/commit/125cc22996a91498fb075ba1fd2de829603a6c61) proto: move UdpClientStreamBuilder below UdpClientStream ### 📊 Changes **1 file changed** (+400 additions, -400 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/udp/udp_client_stream.rs` (+400 -400) </details> ### 📄 Description Ended up looking at the code from - #3311 some more, I think this makes stuff a little nicer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>