[PR #3341] [MERGED] Undo case randomization in active requests key #3755

New issue

Closed

opened 2026-03-16 12:01:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:01:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3341
Author: @divergentdave
Created: 10/31/2025
Status: ✅ Merged
Merged: 11/4/2025
Merged by: @djc

Base: main ← Head: david/cache-key-no-case-randomization

📝 Commits (2)

de9e77e Enable case randomization in shared lookup test
661c186 Use separate struct as key of active requests

📊 Changes

3 files changed (+50 additions, -12 deletions)

View changed files

📝 crates/resolver/src/name_server_pool.rs (+46 -11)
📝 crates/resolver/tests/tests.rs (+2 -1)
📝 tests/test-support/src/lib.rs (+2 -0)

📄 Description

The serialized request used to index into the map of active requests is produced after query name randomization is applied. Thus, we need to substitute the original query, in addition to clearing the transaction ID, in order to reliably memoize concurrent requests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3341 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 10/31/2025 **Status:** ✅ Merged **Merged:** 11/4/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/cache-key-no-case-randomization` --- ### 📝 Commits (2) - [`de9e77e`](https://github.com/hickory-dns/hickory-dns/commit/de9e77e145d58119f7b59171a091387641141f7e) Enable case randomization in shared lookup test - [`661c186`](https://github.com/hickory-dns/hickory-dns/commit/661c186b2243ce7a797e4c0d4e25f4c0f64e57a0) Use separate struct as key of active requests ### 📊 Changes **3 files changed** (+50 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/name_server_pool.rs` (+46 -11) 📝 `crates/resolver/tests/tests.rs` (+2 -1) 📝 `tests/test-support/src/lib.rs` (+2 -0) </details> ### 📄 Description The serialized request used to index into the map of active requests is produced after query name randomization is applied. Thus, we need to substitute the original query, in addition to clearing the transaction ID, in order to reliably memoize concurrent requests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>