[PR #3329] [MERGED] Change MessageSigner to use 64-bit timestamp #3750

New issue

Closed

opened 2026-03-16 12:00:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:00:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3329
Author: @divergentdave
Created: 10/24/2025
Status: ✅ Merged
Merged: 10/25/2025
Merged by: @djc

Base: main ← Head: david/message-signer-64-bit-timestamp

📝 Commits (1)

41de424 Change MessageSigner to use 64-bit timestamp

📊 Changes

6 files changed (+17 additions, -17 deletions)

View changed files

📝 crates/proto/src/dnssec/signer.rs (+5 -2)
📝 crates/proto/src/dnssec/tsig.rs (+3 -4)
📝 crates/proto/src/op/message.rs (+2 -2)
📝 crates/proto/src/udp/udp_client_stream.rs (+1 -2)
📝 crates/proto/src/xfer/dns_multiplexer.rs (+1 -2)
📝 tests/integration-tests/tests/integration/sqlite_zone_handler_tests.rs (+5 -5)

📄 Description

This makes the change I described in https://github.com/hickory-dns/hickory-dns/pull/3311#discussion_r2462176455, fixing some TODOs. We should be using a wider type here because TSIG signatures have 48-bit timestamps. Truncation to 32 bits should only be done when signing with SIG(0).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3329 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 10/24/2025 **Status:** ✅ Merged **Merged:** 10/25/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/message-signer-64-bit-timestamp` --- ### 📝 Commits (1) - [`41de424`](https://github.com/hickory-dns/hickory-dns/commit/41de424b8b95dfe6507c40a83ea73491e29cdabd) Change MessageSigner to use 64-bit timestamp ### 📊 Changes **6 files changed** (+17 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/dnssec/signer.rs` (+5 -2) 📝 `crates/proto/src/dnssec/tsig.rs` (+3 -4) 📝 `crates/proto/src/op/message.rs` (+2 -2) 📝 `crates/proto/src/udp/udp_client_stream.rs` (+1 -2) 📝 `crates/proto/src/xfer/dns_multiplexer.rs` (+1 -2) 📝 `tests/integration-tests/tests/integration/sqlite_zone_handler_tests.rs` (+5 -5) </details> ### 📄 Description This makes the change I described in https://github.com/hickory-dns/hickory-dns/pull/3311#discussion_r2462176455, fixing some TODOs. We should be using a wider type here because TSIG signatures have 48-bit timestamps. Truncation to 32 bits should only be done when signing with SIG(0). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>