[PR #3319] [MERGED] Generalize answer filtering #3740

New issue

Closed

opened 2026-03-16 12:00:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:00:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3319
Author: @marcus0x62
Created: 10/19/2025
Status: ✅ Merged
Merged: 10/21/2025
Merged by: @marcus0x62

Base: main ← Head: generalize-answer-filtering

📝 Commits (4)

bf79a25 proto: move AccessControlSet to proto
a5ba403 resolver: move answer filtering from recursor to resolver
b81b015 resolver: allow resolver users to specify answer filtering
e4c8a32 conformance: add do_not_answer test for the forwarder

📊 Changes

18 files changed (+414 additions, -188 deletions)

View changed files

📝 Cargo.lock (+2 -1)
📝 conformance/dns-test/src/forwarder.rs (+17 -4)
➕ conformance/e2e-tests/src/forwarder.rs (+1 -0)
➕ conformance/e2e-tests/src/forwarder/do_not_answer.rs (+95 -0)
➕ conformance/e2e-tests/src/forwarder/do_not_answer.toml.jinja (+16 -0)
📝 conformance/e2e-tests/src/lib.rs (+1 -0)
📝 crates/proto/Cargo.toml (+3 -0)
➕ crates/proto/src/access_control.rs (+163 -0)
📝 crates/proto/src/lib.rs (+2 -0)
📝 crates/recursor/Cargo.toml (+1 -2)
📝 crates/recursor/src/lib.rs (+1 -147)
📝 crates/recursor/src/recursor.rs (+2 -1)
📝 crates/recursor/src/recursor_dns_handle.rs (+5 -21)
📝 crates/resolver/Cargo.toml (+2 -1)
📝 crates/resolver/src/config.rs (+8 -0)
📝 crates/resolver/src/name_server/name_server_pool.rs (+70 -6)
📝 crates/resolver/src/resolver.rs (+19 -5)
📝 tests/test-data/test_configs/example_forwarder.toml (+6 -0)

📄 Description

This moves answer filtering into the resolver and adds configuration options to enable it for resolver and forwarder users. This should close out the remaining use cases from #347.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3319 **Author:** [@marcus0x62](https://github.com/marcus0x62) **Created:** 10/19/2025 **Status:** ✅ Merged **Merged:** 10/21/2025 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `generalize-answer-filtering` --- ### 📝 Commits (4) - [`bf79a25`](https://github.com/hickory-dns/hickory-dns/commit/bf79a253bcf0ade97c969af07d4d227d6d50980b) proto: move AccessControlSet to proto - [`a5ba403`](https://github.com/hickory-dns/hickory-dns/commit/a5ba40372a21a9a490d30d244513b98b01247c4c) resolver: move answer filtering from recursor to resolver - [`b81b015`](https://github.com/hickory-dns/hickory-dns/commit/b81b0156a88de2414134aeda991edce26ddfb318) resolver: allow resolver users to specify answer filtering - [`e4c8a32`](https://github.com/hickory-dns/hickory-dns/commit/e4c8a327db990b9447fd7a060d8e811014fc6516) conformance: add do_not_answer test for the forwarder ### 📊 Changes **18 files changed** (+414 additions, -188 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+2 -1) 📝 `conformance/dns-test/src/forwarder.rs` (+17 -4) ➕ `conformance/e2e-tests/src/forwarder.rs` (+1 -0) ➕ `conformance/e2e-tests/src/forwarder/do_not_answer.rs` (+95 -0) ➕ `conformance/e2e-tests/src/forwarder/do_not_answer.toml.jinja` (+16 -0) 📝 `conformance/e2e-tests/src/lib.rs` (+1 -0) 📝 `crates/proto/Cargo.toml` (+3 -0) ➕ `crates/proto/src/access_control.rs` (+163 -0) 📝 `crates/proto/src/lib.rs` (+2 -0) 📝 `crates/recursor/Cargo.toml` (+1 -2) 📝 `crates/recursor/src/lib.rs` (+1 -147) 📝 `crates/recursor/src/recursor.rs` (+2 -1) 📝 `crates/recursor/src/recursor_dns_handle.rs` (+5 -21) 📝 `crates/resolver/Cargo.toml` (+2 -1) 📝 `crates/resolver/src/config.rs` (+8 -0) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+70 -6) 📝 `crates/resolver/src/resolver.rs` (+19 -5) 📝 `tests/test-data/test_configs/example_forwarder.toml` (+6 -0) </details> ### 📄 Description This moves answer filtering into the resolver and adds configuration options to enable it for resolver and forwarder users. This should close out the remaining use cases from #347. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>