[PR #3316] [MERGED] Conformance tests: Defer printing output when command fails #3738

New issue

Closed

opened 2026-03-16 11:59:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:59:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3316
Author: @divergentdave
Created: 10/16/2025
Status: ✅ Merged
Merged: 10/17/2025
Merged by: @djc

Base: main ← Head: david/conformance-quiet-wait

📝 Commits (1)

6a49553 Defer printing output when command fails

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 conformance/dns-test/src/container.rs (+5 -3)

📄 Description

This replaces an eprintln!() in Container::stdout() when an executed command fails. The output of the failed command is instead returned via Result::Err. The Container::wait() method may cause some spurious command failures while it is polling to check log files, in case it tries to run cat before log files have been created. With this change, the cat error messages get swallowed when the error is swallowed in the polling loop, instead of showing up in test output.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3316 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 10/16/2025 **Status:** ✅ Merged **Merged:** 10/17/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/conformance-quiet-wait` --- ### 📝 Commits (1) - [`6a49553`](https://github.com/hickory-dns/hickory-dns/commit/6a49553147bf8fd7f4444f51641f006af122bc1f) Defer printing output when command fails ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `conformance/dns-test/src/container.rs` (+5 -3) </details> ### 📄 Description This replaces an `eprintln!()` in `Container::stdout()` when an executed command fails. The output of the failed command is instead returned via `Result::Err`. The `Container::wait()` method may cause some spurious command failures while it is polling to check log files, in case it tries to run `cat` before log files have been created. With this change, the `cat` error messages get swallowed when the error is swallowed in the polling loop, instead of showing up in test output. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>