[PR #3312] [MERGED] Fix flaky RRSIG TTL test #3731

New issue

Closed

opened 2026-03-16 11:59:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:59:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3312
Author: @msrd0
Created: 10/14/2025
Status: ✅ Merged
Merged: 10/14/2025
Merged by: @cpu

Base: main ← Head: msrd0/fix-rrsig-test

📝 Commits (1)

2f6a9a9 Fix flaky RRSIG TTL test

📊 Changes

1 file changed (+16 additions, -18 deletions)

View changed files

📝 bin/tests/integration/named_test_rsa_dnssec.rs (+16 -18)

📄 Description

It turns out that fetching all DNS responses as part of the test can have one of two outcomes:

stall for 10s and then return None
fail because the stream closed

This PR changes the test to only fetch the first response. I tested it like 20 times on my local computer and didn't see a single test failure.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3312 **Author:** [@msrd0](https://github.com/msrd0) **Created:** 10/14/2025 **Status:** ✅ Merged **Merged:** 10/14/2025 **Merged by:** [@cpu](https://github.com/cpu) **Base:** `main` ← **Head:** `msrd0/fix-rrsig-test` --- ### 📝 Commits (1) - [`2f6a9a9`](https://github.com/hickory-dns/hickory-dns/commit/2f6a9a91d50fbbe45852e8a3011f398e8c6731fd) Fix flaky RRSIG TTL test ### 📊 Changes **1 file changed** (+16 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+16 -18) </details> ### 📄 Description It turns out that fetching all DNS responses as part of the test can have one of two outcomes: - stall for 10s and then return None - fail because the stream closed This PR changes the test to only fetch the first response. I tested it like 20 times on my local computer and didn't see a single test failure. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>