[PR #3269] [MERGED] replace manual Default impl for enums #3696

New issue

Closed

opened 2026-03-16 11:57:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:57:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3269
Author: @cpu
Created: 9/10/2025
Status: ✅ Merged
Merged: 9/10/2025
Merged by: @cpu

Base: main ← Head: cpu-enum-defauts_dev

📝 Commits (1)

d368ebb replace manual Default impl for enums

📊 Changes

5 files changed (+18 additions, -65 deletions)

View changed files

📝 conformance/dns-test/src/implementation.rs (+2 -7)
📝 crates/proto/src/dnssec/rdata/key.rs (+6 -21)
📝 crates/proto/src/op/response_code.rs (+2 -7)
📝 crates/resolver/src/config.rs (+4 -16)
📝 crates/server/src/zone_handler/auth_lookup.rs (+4 -14)

📄 Description

Use the #[default] syntax on a variant and a derived Default instead.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3269 **Author:** [@cpu](https://github.com/cpu) **Created:** 9/10/2025 **Status:** ✅ Merged **Merged:** 9/10/2025 **Merged by:** [@cpu](https://github.com/cpu) **Base:** `main` ← **Head:** `cpu-enum-defauts_dev` --- ### 📝 Commits (1) - [`d368ebb`](https://github.com/hickory-dns/hickory-dns/commit/d368ebbc6fed464823d72faf0552e675f395cf1c) replace manual Default impl for enums ### 📊 Changes **5 files changed** (+18 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `conformance/dns-test/src/implementation.rs` (+2 -7) 📝 `crates/proto/src/dnssec/rdata/key.rs` (+6 -21) 📝 `crates/proto/src/op/response_code.rs` (+2 -7) 📝 `crates/resolver/src/config.rs` (+4 -16) 📝 `crates/server/src/zone_handler/auth_lookup.rs` (+4 -14) </details> ### 📄 Description Use the `#[default]` syntax on a variant and a derived `Default` instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>