[PR #3263] [MERGED] NameServerPool tweaks #3691

New issue

Closed

opened 2026-03-16 11:57:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:57:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3263
Author: @djc
Created: 9/5/2025
Status: ✅ Merged
Merged: 9/5/2025
Merged by: @djc

Base: main ← Head: pool-cleanup

📝 Commits (4)

658019e resolver: sort directly on bool
065d0bd resolver: remove custom Debug impl for NameServer
471318a resolver: remove intermediate NameServerState layer
f84ae14 resolver: discard low-value constructor

📊 Changes

4 files changed (+92 additions, -148 deletions)

View changed files

📝 crates/resolver/src/name_server/name_server.rs (+52 -99)
📝 crates/resolver/src/name_server/name_server_pool.rs (+29 -38)
📝 crates/resolver/src/resolver.rs (+2 -2)
📝 tests/integration-tests/tests/integration/name_server_pool_tests.rs (+9 -9)

📄 Description

Some followup from

#3210

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3263 **Author:** [@djc](https://github.com/djc) **Created:** 9/5/2025 **Status:** ✅ Merged **Merged:** 9/5/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `pool-cleanup` --- ### 📝 Commits (4) - [`658019e`](https://github.com/hickory-dns/hickory-dns/commit/658019eeba19e92de5003726eb076c959a36e2f3) resolver: sort directly on bool - [`065d0bd`](https://github.com/hickory-dns/hickory-dns/commit/065d0bd9752f490ece156d4ff3ce65ca59843fe8) resolver: remove custom Debug impl for NameServer - [`471318a`](https://github.com/hickory-dns/hickory-dns/commit/471318abbfb2eef0dacc2b2ce8a320c7b5ecd43d) resolver: remove intermediate NameServerState layer - [`f84ae14`](https://github.com/hickory-dns/hickory-dns/commit/f84ae142520816823c1a419b6d4a14998abeefbc) resolver: discard low-value constructor ### 📊 Changes **4 files changed** (+92 additions, -148 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/name_server/name_server.rs` (+52 -99) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+29 -38) 📝 `crates/resolver/src/resolver.rs` (+2 -2) 📝 `tests/integration-tests/tests/integration/name_server_pool_tests.rs` (+9 -9) </details> ### 📄 Description Some followup from - #3210 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>