[PR #3256] [MERGED] resolver: rm tokio NameServerPool constructor #3688

New issue

Closed

opened 2026-03-16 11:57:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:57:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3256
Author: @cpu
Created: 9/3/2025
Status: ✅ Merged
Merged: 9/3/2025
Merged by: @cpu

Base: main ← Head: cpu-tokio-tidy_dev

📝 Commits (1)

908e198 resolver: rm tokio NameServerPool constructor

📊 Changes

1 file changed (+1 additions, -12 deletions)

View changed files

📝 crates/resolver/src/name_server/name_server_pool.rs (+1 -12)

📄 Description

I was feeling left out of all of the nice tidying PRs landing today so here's a quick one of my own 😝

This thin test helper isn't necessary, from_config_with_provider() works for this test's needs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3256 **Author:** [@cpu](https://github.com/cpu) **Created:** 9/3/2025 **Status:** ✅ Merged **Merged:** 9/3/2025 **Merged by:** [@cpu](https://github.com/cpu) **Base:** `main` ← **Head:** `cpu-tokio-tidy_dev` --- ### 📝 Commits (1) - [`908e198`](https://github.com/hickory-dns/hickory-dns/commit/908e1986fe04714a363773ae8651fac8526fb824) resolver: rm tokio NameServerPool constructor ### 📊 Changes **1 file changed** (+1 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+1 -12) </details> ### 📄 Description I was feeling left out of all of the nice tidying PRs landing today so here's a quick one of my own :stuck_out_tongue_closed_eyes: This thin test helper isn't necessary, `from_config_with_provider()` works for this test's needs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>