[PR #3259] [MERGED] proto: doc justification for Lower[Query/Name] #3687

New issue

Closed

opened 2026-03-16 11:57:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:57:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3259
Author: @cpu
Created: 9/4/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @cpu

Base: main ← Head: cpu-justify-lower-name

📝 Commits (1)

f80991a proto: doc justification for Lower[Query/Name]

📊 Changes

2 files changed (+12 additions, -3 deletions)

View changed files

📝 crates/proto/src/op/lower_query.rs (+5 -1)
📝 crates/proto/src/rr/lower_name.rs (+7 -2)

📄 Description

This way we won't try to refactor it away in the future without having a hint that it's load-bearing in a perf. sense.

See https://github.com/hickory-dns/hickory-dns/issues/3240

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3259 **Author:** [@cpu](https://github.com/cpu) **Created:** 9/4/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@cpu](https://github.com/cpu) **Base:** `main` ← **Head:** `cpu-justify-lower-name` --- ### 📝 Commits (1) - [`f80991a`](https://github.com/hickory-dns/hickory-dns/commit/f80991afd4e8d087be8258a4a1b2d65d7342cb3c) proto: doc justification for Lower[Query/Name] ### 📊 Changes **2 files changed** (+12 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/lower_query.rs` (+5 -1) 📝 `crates/proto/src/rr/lower_name.rs` (+7 -2) </details> ### 📄 Description This way we won't try to refactor it away in the future without having a hint that it's load-bearing in a perf. sense. See https://github.com/hickory-dns/hickory-dns/issues/3240 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>