[PR #3255] [CLOSED] Remove LowerQuery and LowerName #3683

New issue

Closed

opened 2026-03-16 11:56:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:56:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3255
Author: @divergentdave
Created: 9/3/2025
Status: ❌ Closed

Base: main ← Head: david/remove-lower-query-lower-name

📝 Commits (2)

b86da88 Remove LowerQuery and LowerName
ea50f4a Remove more unncecessary type annotations

📊 Changes

50 files changed (+793 additions, -827 deletions)

View changed files

📝 bin/src/hickory-dns.rs (+1 -1)
📝 bin/tests/integration/forwarder.rs (+1 -1)
📝 bin/tests/integration/in_memory.rs (+3 -3)
📝 bin/tests/integration/named_metrics_tests.rs (+1 -1)
📝 bin/tests/integration/store_file_tests.rs (+6 -6)
📝 bin/tests/integration/txt_tests.rs (+23 -31)
📝 bin/tests/integration/zone_handler_battery/dnssec.rs (+5 -9)
📝 bin/tests/integration/zone_handler_battery/dynamic_update.rs (+1 -1)
📝 crates/proto/benches/lower_name_benches.rs (+13 -13)
📝 crates/proto/src/dnssec/tbs.rs (+1 -1)
📝 crates/proto/src/dnssec/tsig.rs (+6 -6)
➖ crates/proto/src/op/lower_query.rs (+0 -97)
📝 crates/proto/src/op/mod.rs (+0 -3)
➖ crates/proto/src/rr/lower_name.rs (+0 -329)
📝 crates/proto/src/rr/mod.rs (+0 -2)
📝 crates/proto/src/rr/resource.rs (+1 -1)
📝 crates/proto/src/rr/rr_key.rs (+4 -4)
📝 crates/proto/src/serialize/txt/rdata_parsers/mx.rs (+1 -1)
📝 crates/proto/src/serialize/txt/rdata_parsers/name.rs (+1 -1)
📝 crates/proto/src/serialize/txt/rdata_parsers/naptr.rs (+1 -1)

...and 30 more files

📄 Description

This closes #3240.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3255 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 9/3/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `david/remove-lower-query-lower-name` --- ### 📝 Commits (2) - [`b86da88`](https://github.com/hickory-dns/hickory-dns/commit/b86da8874b63ca933a6e061a92a7722726fb8dc3) Remove LowerQuery and LowerName - [`ea50f4a`](https://github.com/hickory-dns/hickory-dns/commit/ea50f4af00a62e4dab3c4984c9269f7c75cfcb74) Remove more unncecessary type annotations ### 📊 Changes **50 files changed** (+793 additions, -827 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/hickory-dns.rs` (+1 -1) 📝 `bin/tests/integration/forwarder.rs` (+1 -1) 📝 `bin/tests/integration/in_memory.rs` (+3 -3) 📝 `bin/tests/integration/named_metrics_tests.rs` (+1 -1) 📝 `bin/tests/integration/store_file_tests.rs` (+6 -6) 📝 `bin/tests/integration/txt_tests.rs` (+23 -31) 📝 `bin/tests/integration/zone_handler_battery/dnssec.rs` (+5 -9) 📝 `bin/tests/integration/zone_handler_battery/dynamic_update.rs` (+1 -1) 📝 `crates/proto/benches/lower_name_benches.rs` (+13 -13) 📝 `crates/proto/src/dnssec/tbs.rs` (+1 -1) 📝 `crates/proto/src/dnssec/tsig.rs` (+6 -6) ➖ `crates/proto/src/op/lower_query.rs` (+0 -97) 📝 `crates/proto/src/op/mod.rs` (+0 -3) ➖ `crates/proto/src/rr/lower_name.rs` (+0 -329) 📝 `crates/proto/src/rr/mod.rs` (+0 -2) 📝 `crates/proto/src/rr/resource.rs` (+1 -1) 📝 `crates/proto/src/rr/rr_key.rs` (+4 -4) 📝 `crates/proto/src/serialize/txt/rdata_parsers/mx.rs` (+1 -1) 📝 `crates/proto/src/serialize/txt/rdata_parsers/name.rs` (+1 -1) 📝 `crates/proto/src/serialize/txt/rdata_parsers/naptr.rs` (+1 -1) _...and 30 more files_ </details> ### 📄 Description This closes #3240. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>