[PR #3253] [MERGED] Make fields of HeaderCounts private #3682

New issue

Closed

opened 2026-03-16 11:56:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:56:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3253
Author: @divergentdave
Created: 9/3/2025
Status: ✅ Merged
Merged: 9/3/2025
Merged by: @divergentdave

Base: main ← Head: david/header-counts-fields-private

📝 Commits (1)

d6ce4ad Make fields of HeaderCounts private

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 crates/proto/src/op/message.rs (+4 -4)

📄 Description

I noticed that the 1.75 toolchain was warning about some unreachable_pub lints on the fields of HeaderCounts. This struct is not used outside of its module, much less exported, so we can just make these fields private.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3253 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 9/3/2025 **Status:** ✅ Merged **Merged:** 9/3/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/header-counts-fields-private` --- ### 📝 Commits (1) - [`d6ce4ad`](https://github.com/hickory-dns/hickory-dns/commit/d6ce4ade01331c45114e74ee5f6625bac1d17730) Make fields of HeaderCounts private ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/message.rs` (+4 -4) </details> ### 📄 Description I noticed that the 1.75 toolchain was warning about some `unreachable_pub` lints on the fields of `HeaderCounts`. This struct is not used outside of its module, much less exported, so we can just make these fields private. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>