[PR #3250] [MERGED] server: simplify ZoneHandler interface #3678

New issue

Closed

opened 2026-03-16 11:56:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:56:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3250
Author: @djc
Created: 9/3/2025
Status: ✅ Merged
Merged: 9/3/2025
Merged by: @djc

Base: main ← Head: authority-interface

📝 Commits (6)

90c5209 server: rely on default implementations for ns(), soa() and soa_secure()
b127bce server: inline Authority::ns() method
b460bed server: drop trivial module
1f96fd6 server: inline Authority::soa_secure() method
00d7878 server: inline Authority::soa() method
453147e server: merge nested zone_handler module

📊 Changes

9 files changed (+526 additions, -539 deletions)

View changed files

📝 bin/tests/integration/txt_tests.rs (+9 -6)
📝 bin/tests/integration/zone_handler_battery/basic.rs (+14 -2)
📝 bin/tests/integration/zone_handler_battery/dnssec.rs (+14 -2)
📝 crates/server/src/store/file.rs (+0 -18)
📝 crates/server/src/store/in_memory/mod.rs (+14 -7)
📝 crates/server/src/zone_handler/catalog.rs (+4 -2)
📝 crates/server/src/zone_handler/mod.rs (+441 -20)
➖ crates/server/src/zone_handler/zone_handler.rs (+0 -478)
📝 tests/integration-tests/tests/integration/sqlite_zone_handler_tests.rs (+30 -4)

📄 Description

Part of

#3169

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3250 **Author:** [@djc](https://github.com/djc) **Created:** 9/3/2025 **Status:** ✅ Merged **Merged:** 9/3/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `authority-interface` --- ### 📝 Commits (6) - [`90c5209`](https://github.com/hickory-dns/hickory-dns/commit/90c5209242267b166e8403ee8dfe9161b0d24a9c) server: rely on default implementations for ns(), soa() and soa_secure() - [`b127bce`](https://github.com/hickory-dns/hickory-dns/commit/b127bcee6830bd26109fa0dbc51035a7b06799c5) server: inline Authority::ns() method - [`b460bed`](https://github.com/hickory-dns/hickory-dns/commit/b460bed1fca2449796e359828a38fdbe509669ae) server: drop trivial module - [`1f96fd6`](https://github.com/hickory-dns/hickory-dns/commit/1f96fd680c089f3cec949174de19bdf08adb9241) server: inline Authority::soa_secure() method - [`00d7878`](https://github.com/hickory-dns/hickory-dns/commit/00d7878cee8d140b5285466741cb450d2b9ffec0) server: inline Authority::soa() method - [`453147e`](https://github.com/hickory-dns/hickory-dns/commit/453147e35986d46d23699cd9d6dcdefd9fe54303) server: merge nested zone_handler module ### 📊 Changes **9 files changed** (+526 additions, -539 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/txt_tests.rs` (+9 -6) 📝 `bin/tests/integration/zone_handler_battery/basic.rs` (+14 -2) 📝 `bin/tests/integration/zone_handler_battery/dnssec.rs` (+14 -2) 📝 `crates/server/src/store/file.rs` (+0 -18) 📝 `crates/server/src/store/in_memory/mod.rs` (+14 -7) 📝 `crates/server/src/zone_handler/catalog.rs` (+4 -2) 📝 `crates/server/src/zone_handler/mod.rs` (+441 -20) ➖ `crates/server/src/zone_handler/zone_handler.rs` (+0 -478) 📝 `tests/integration-tests/tests/integration/sqlite_zone_handler_tests.rs` (+30 -4) </details> ### 📄 Description Part of - #3169 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>