[PR #3245] [MERGED] bin: use default log formatting #3676

New issue

Closed

opened 2026-03-16 11:56:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:56:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3245
Author: @djc
Created: 9/1/2025
Status: ✅ Merged
Merged: 9/3/2025
Merged by: @djc

Base: main ← Head: log-formatting

📝 Commits (2)

21b6543 bin: use default log formatting
7273d03 proto: reduce logging from TCP stream

📊 Changes

2 files changed (+13 additions, -78 deletions)

View changed files

📝 bin/src/hickory-dns.rs (+3 -66)
📝 crates/proto/src/tcp/tcp_stream.rs (+10 -12)

📄 Description

Before (custom):

1756740658:WARN:hickory_recursor::recursor_dns_handle:392:lookup error: stream closed
1756740658:DEBUG:hickory_server::authority::catalog:997:error resolving error=RecursiveError(Error { kind: Proto(ProtoError { kind: Message("stream closed") }) })
1756740658:DEBUG:hickory_server::server::response_handler:106:sending response id=51559 response_code=Server Failure
1756740658:INFO:hickory_server::server:715:request:51559 src:udp://192.168.117.5#43839 QUERY qflags:RD response:ServFail rr:0/0/1 rflags:RD,RA
1756740658:INFO:hickory_server::server:730:query:example-123.testing.:A:IN

After (default):

2025-09-01T20:11:02.362823Z  WARN hickory_recursor::recursor_dns_handle: lookup error: io error: Broken pipe (os error 32)
2025-09-01T20:11:02.362886Z DEBUG hickory_server::authority::catalog: error resolving error=RecursiveError(Error { kind: Proto(ProtoError { kind: Io(Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }) }) })
2025-09-01T20:11:02.362907Z DEBUG hickory_server::server::response_handler: sending response id=2046 response_code=Server Failure
2025-09-01T20:11:02.362933Z  INFO hickory_server::server: request:2046 src:udp://192.168.117.5#37536 QUERY qflags:RD response:ServFail rr:0/0/1 rflags:RD,RA
2025-09-01T20:11:02.362951Z  INFO hickory_server::server: query:example-123.testing.:A:IN

The old style seems very optimized for conciseness but I think I prefer things to have human-readable timestamps and a dash of whitespace.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3245 **Author:** [@djc](https://github.com/djc) **Created:** 9/1/2025 **Status:** ✅ Merged **Merged:** 9/3/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `log-formatting` --- ### 📝 Commits (2) - [`21b6543`](https://github.com/hickory-dns/hickory-dns/commit/21b65435f6ea3c2abc03c703219b786038f7fc0b) bin: use default log formatting - [`7273d03`](https://github.com/hickory-dns/hickory-dns/commit/7273d03b450558b39272520484f7dda87cf3b482) proto: reduce logging from TCP stream ### 📊 Changes **2 files changed** (+13 additions, -78 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/hickory-dns.rs` (+3 -66) 📝 `crates/proto/src/tcp/tcp_stream.rs` (+10 -12) </details> ### 📄 Description Before (custom): ``` 1756740658:WARN:hickory_recursor::recursor_dns_handle:392:lookup error: stream closed 1756740658:DEBUG:hickory_server::authority::catalog:997:error resolving error=RecursiveError(Error { kind: Proto(ProtoError { kind: Message("stream closed") }) }) 1756740658:DEBUG:hickory_server::server::response_handler:106:sending response id=51559 response_code=Server Failure 1756740658:INFO:hickory_server::server:715:request:51559 src:udp://192.168.117.5#43839 QUERY qflags:RD response:ServFail rr:0/0/1 rflags:RD,RA 1756740658:INFO:hickory_server::server:730:query:example-123.testing.:A:IN ``` After (default): ``` 2025-09-01T20:11:02.362823Z WARN hickory_recursor::recursor_dns_handle: lookup error: io error: Broken pipe (os error 32) 2025-09-01T20:11:02.362886Z DEBUG hickory_server::authority::catalog: error resolving error=RecursiveError(Error { kind: Proto(ProtoError { kind: Io(Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }) }) }) 2025-09-01T20:11:02.362907Z DEBUG hickory_server::server::response_handler: sending response id=2046 response_code=Server Failure 2025-09-01T20:11:02.362933Z INFO hickory_server::server: request:2046 src:udp://192.168.117.5#37536 QUERY qflags:RD response:ServFail rr:0/0/1 rflags:RD,RA 2025-09-01T20:11:02.362951Z INFO hickory_server::server: query:example-123.testing.:A:IN ``` The old style seems very optimized for conciseness but I think I prefer things to have human-readable timestamps and a dash of whitespace. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>