[PR #3234] [MERGED] server: simplify time handling #3668

New issue

Closed

opened 2026-03-16 11:56:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:56:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3234
Author: @djc
Created: 8/26/2025
Status: ✅ Merged
Merged: 8/27/2025
Merged by: @djc

Base: main ← Head: server-time

📝 Commits (4)

deadf81 server: provide default implementation for Authority::update()
ccdd9cd server: inline UpdateResult type alias
5328ae0 server: provide default implementation for Authority::zone_transfer()
e2f559a server: hoist timestamp retrieval out of update methods

📊 Changes

18 files changed (+248 additions, -237 deletions)

View changed files

📝 bin/tests/integration/authority_battery/basic.rs (+6 -1)
📝 bin/tests/integration/authority_battery/dynamic_update.rs (+4 -3)
📝 crates/server/src/authority/authority.rs (+13 -7)
📝 crates/server/src/authority/catalog.rs (+15 -5)
📝 crates/server/src/authority/mod.rs (+0 -3)
📝 crates/server/src/server/mod.rs (+4 -2)
📝 crates/server/src/server/request_handler.rs (+2 -1)
📝 crates/server/src/store/blocklist.rs (+3 -9)
📝 crates/server/src/store/file.rs (+5 -11)
📝 crates/server/src/store/forwarder.rs (+2 -26)
📝 crates/server/src/store/in_memory/mod.rs (+2 -65)
📝 crates/server/src/store/recursor.rs (+2 -27)
📝 crates/server/src/store/sqlite/mod.rs (+21 -16)
📝 tests/integration-tests/src/lib.rs (+1 -1)
📝 tests/integration-tests/src/mock_request_handler.rs (+2 -1)
📝 tests/integration-tests/tests/integration/catalog_tests.rs (+77 -16)
📝 tests/integration-tests/tests/integration/chained_authority_tests.rs (+5 -22)
📝 tests/integration-tests/tests/integration/sqlite_authority_tests.rs (+84 -21)

📄 Description

From reviewing

#3228

and as noted before in https://github.com/hickory-dns/hickory-dns/pull/3158#issuecomment-3205615317, I'm not sure the current usage of RuntimeProvider makes sense for the server crate (which has a mandatory dependency on Tokio today).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3234 **Author:** [@djc](https://github.com/djc) **Created:** 8/26/2025 **Status:** ✅ Merged **Merged:** 8/27/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `server-time` --- ### 📝 Commits (4) - [`deadf81`](https://github.com/hickory-dns/hickory-dns/commit/deadf81784a9a67da82038942b531bc8e9cad379) server: provide default implementation for Authority::update() - [`ccdd9cd`](https://github.com/hickory-dns/hickory-dns/commit/ccdd9cdb99709c40263b208fb8413e70df521126) server: inline UpdateResult type alias - [`5328ae0`](https://github.com/hickory-dns/hickory-dns/commit/5328ae044abc5b200ef47549232fff9cf4107bc7) server: provide default implementation for Authority::zone_transfer() - [`e2f559a`](https://github.com/hickory-dns/hickory-dns/commit/e2f559a865880811617c68f4aa64123a5c8ff77a) server: hoist timestamp retrieval out of update methods ### 📊 Changes **18 files changed** (+248 additions, -237 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/basic.rs` (+6 -1) 📝 `bin/tests/integration/authority_battery/dynamic_update.rs` (+4 -3) 📝 `crates/server/src/authority/authority.rs` (+13 -7) 📝 `crates/server/src/authority/catalog.rs` (+15 -5) 📝 `crates/server/src/authority/mod.rs` (+0 -3) 📝 `crates/server/src/server/mod.rs` (+4 -2) 📝 `crates/server/src/server/request_handler.rs` (+2 -1) 📝 `crates/server/src/store/blocklist.rs` (+3 -9) 📝 `crates/server/src/store/file.rs` (+5 -11) 📝 `crates/server/src/store/forwarder.rs` (+2 -26) 📝 `crates/server/src/store/in_memory/mod.rs` (+2 -65) 📝 `crates/server/src/store/recursor.rs` (+2 -27) 📝 `crates/server/src/store/sqlite/mod.rs` (+21 -16) 📝 `tests/integration-tests/src/lib.rs` (+1 -1) 📝 `tests/integration-tests/src/mock_request_handler.rs` (+2 -1) 📝 `tests/integration-tests/tests/integration/catalog_tests.rs` (+77 -16) 📝 `tests/integration-tests/tests/integration/chained_authority_tests.rs` (+5 -22) 📝 `tests/integration-tests/tests/integration/sqlite_authority_tests.rs` (+84 -21) </details> ### 📄 Description From reviewing - #3228 and as noted before in https://github.com/hickory-dns/hickory-dns/pull/3158#issuecomment-3205615317, I'm not sure the current usage of `RuntimeProvider` makes sense for the server crate (which has a mandatory dependency on Tokio today). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>