[PR #3236] [MERGED] Fix commented-out tests #3667

New issue

Closed

opened 2026-03-16 11:56:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:56:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3236
Author: @divergentdave
Created: 8/26/2025
Status: ✅ Merged
Merged: 8/27/2025
Merged by: @djc

Base: main ← Head: david/fix-dnssec-tests

📝 Commits (1)

8fe22c9 Fix commented-out tests

📊 Changes

1 file changed (+33 additions, -34 deletions)

View changed files

📝 bin/tests/integration/authority_battery/dnssec.rs (+33 -34)

📄 Description

This fixes a couple commented-out sections of a test battery. Private key loading was revamped a while back, so it now works for all algorithms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3236 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 8/26/2025 **Status:** ✅ Merged **Merged:** 8/27/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/fix-dnssec-tests` --- ### 📝 Commits (1) - [`8fe22c9`](https://github.com/hickory-dns/hickory-dns/commit/8fe22c9619b30c38d96465a224dcc9108e0dcb09) Fix commented-out tests ### 📊 Changes **1 file changed** (+33 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+33 -34) </details> ### 📄 Description This fixes a couple commented-out sections of a test battery. Private key loading was revamped a while back, so it now works for all algorithms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>