[PR #3223] [MERGED] Strict check for SOA RR at zone apex #3656

New issue

Closed

opened 2026-03-16 11:55:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:55:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3223
Author: @divergentdave
Created: 8/20/2025
Status: ✅ Merged
Merged: 8/20/2025
Merged by: @divergentdave

Base: main ← Head: david/strict-soa-at-origin

📝 Commits (2)

19737b3 Always treat origin as FQDN when parsing zone file
6b0d7e4 Make SOA check more strict

📊 Changes

3 files changed (+15 additions, -11 deletions)

View changed files

📝 crates/proto/src/serialize/txt/zone.rs (+4 -1)
📝 crates/server/src/store/in_memory/mod.rs (+6 -8)
📝 tests/integration-tests/tests/integration/truncation_tests.rs (+5 -2)

📄 Description

This PR makes some of the authority constructors more strict, checking for an SOA record at the origin, instead of checking for any SOA record. I had to fix two integration tests as a result, and I fixed one by making the zone parser always treat the origin an FQDN.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3223 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 8/20/2025 **Status:** ✅ Merged **Merged:** 8/20/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/strict-soa-at-origin` --- ### 📝 Commits (2) - [`19737b3`](https://github.com/hickory-dns/hickory-dns/commit/19737b3267cc8b782f56a1ff74046ac0c43c316c) Always treat origin as FQDN when parsing zone file - [`6b0d7e4`](https://github.com/hickory-dns/hickory-dns/commit/6b0d7e4523afb378f23a96211e522a6a83e613d6) Make SOA check more strict ### 📊 Changes **3 files changed** (+15 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/serialize/txt/zone.rs` (+4 -1) 📝 `crates/server/src/store/in_memory/mod.rs` (+6 -8) 📝 `tests/integration-tests/tests/integration/truncation_tests.rs` (+5 -2) </details> ### 📄 Description This PR makes some of the authority constructors more strict, checking for an SOA record at the origin, instead of checking for any SOA record. I had to fix two integration tests as a result, and I fixed one by making the zone parser always treat the origin an FQDN. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>