[PR #3224] [MERGED] Clean up conditional compilation #3655

New issue

Closed

opened 2026-03-16 11:55:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:55:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3224
Author: @divergentdave
Created: 8/20/2025
Status: ✅ Merged
Merged: 8/20/2025
Merged by: @divergentdave

Base: main ← Head: david/cfg-feature-cleanup

📝 Commits (6)

52aed92 Clean up cfg guards in SqliteAuthority tests
156083a Fix unused import warning in recursor authority
222232e Tweak cfg guard on UdpStream::from_parts()
3775d23 Adjust cfg guards in PersistentStoreMetrics
bf09e31 Adjust cfg guard in dynamic update tests
95b9b2f Add cfg guards in metrics tests

📊 Changes

6 files changed (+35 additions, -25 deletions)

View changed files

📝 bin/tests/integration/authority_battery/dynamic_update.rs (+1 -1)
📝 bin/tests/integration/named_metrics_tests.rs (+9 -4)
📝 crates/proto/src/udp/udp_stream.rs (+1 -1)
📝 crates/server/src/store/metrics.rs (+12 -11)
📝 crates/server/src/store/recursor.rs (+1 -0)
📝 tests/integration-tests/tests/integration/sqlite_authority_tests.rs (+11 -8)

📄 Description

This adjusts #[cfg] attributes to resolve warnings for unused items or imports across the code base, when building with different combinations of features.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3224 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 8/20/2025 **Status:** ✅ Merged **Merged:** 8/20/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/cfg-feature-cleanup` --- ### 📝 Commits (6) - [`52aed92`](https://github.com/hickory-dns/hickory-dns/commit/52aed9254c5bfab9ee28f344a020bb60c9ddb8d7) Clean up cfg guards in SqliteAuthority tests - [`156083a`](https://github.com/hickory-dns/hickory-dns/commit/156083a829bd3a1a1da4d51d798d503f879c73a8) Fix unused import warning in recursor authority - [`222232e`](https://github.com/hickory-dns/hickory-dns/commit/222232e64656553da5a2546b00556d4e403e0cec) Tweak cfg guard on UdpStream::from_parts() - [`3775d23`](https://github.com/hickory-dns/hickory-dns/commit/3775d23d197fc90c3b0225812ceb6057b68ff0ec) Adjust cfg guards in PersistentStoreMetrics - [`bf09e31`](https://github.com/hickory-dns/hickory-dns/commit/bf09e31e15b849e52c0ca8af28a3f88d4bbbfd28) Adjust cfg guard in dynamic update tests - [`95b9b2f`](https://github.com/hickory-dns/hickory-dns/commit/95b9b2fbe107f2107520a2c9f707980d5d0fec7d) Add cfg guards in metrics tests ### 📊 Changes **6 files changed** (+35 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/dynamic_update.rs` (+1 -1) 📝 `bin/tests/integration/named_metrics_tests.rs` (+9 -4) 📝 `crates/proto/src/udp/udp_stream.rs` (+1 -1) 📝 `crates/server/src/store/metrics.rs` (+12 -11) 📝 `crates/server/src/store/recursor.rs` (+1 -0) 📝 `tests/integration-tests/tests/integration/sqlite_authority_tests.rs` (+11 -8) </details> ### 📄 Description This adjusts `#[cfg]` attributes to resolve warnings for unused items or imports across the code base, when building with different combinations of features. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>