[PR #3216] [MERGED] dns-test: cull dependencies #3654

New issue

Closed

opened 2026-03-16 11:55:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:55:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3216
Author: @djc
Created: 8/19/2025
Status: ✅ Merged
Merged: 8/19/2025
Merged by: @djc

Base: main ← Head: no-serde-with

📝 Commits (5)

5fe117d dns-test: simplify TransportLayer deserialization
fcbf0b6 dns-test: simplify Ip deserialization
11694ab dns-test: drop lazy_static dependency in favor of LazyLock
af60f17 conformance: avoid aliasing Result
b8281b0 dns-test: drop CoreResult alias

📊 Changes

71 files changed (+622 additions, -1817 deletions)

View changed files

📝 conformance/Cargo.lock (+0 -408)
📝 conformance/packages/conformance-tests/src/forwarder/dns/scenarios.rs (+3 -3)
📝 conformance/packages/conformance-tests/src/forwarder/dnssec/scenarios.rs (+4 -4)
📝 conformance/packages/conformance-tests/src/forwarder/dnssec/scenarios/bogus.rs (+3 -3)
📝 conformance/packages/conformance-tests/src/name_server/rfc4035/section_3/section_3_1/section_3_1_1.rs (+3 -3)
📝 conformance/packages/conformance-tests/src/name_server/rfc5155.rs (+9 -9)
📝 conformance/packages/conformance-tests/src/name_server/rfc8906.rs (+3 -3)
📝 conformance/packages/conformance-tests/src/name_server/rfc8906/basic.rs (+10 -10)
📝 conformance/packages/conformance-tests/src/name_server/rfc8906/extended.rs (+11 -11)
📝 conformance/packages/conformance-tests/src/name_server/scenarios.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dns/regression.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dns/rfc1035/truncation.rs (+5 -5)
📝 conformance/packages/conformance-tests/src/resolver/dns/rfc3597.rs (+3 -3)
📝 conformance/packages/conformance-tests/src/resolver/dns/rfc8906.rs (+5 -3)
📝 conformance/packages/conformance-tests/src/resolver/dns/rfc8906/basic.rs (+10 -10)
📝 conformance/packages/conformance-tests/src/resolver/dns/rfc8906/extended.rs (+11 -11)
📝 conformance/packages/conformance-tests/src/resolver/dns/rfc9156.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dns/scenarios.rs (+4 -4)
📝 conformance/packages/conformance-tests/src/resolver/dns/scenarios/bad_referral.rs (+5 -5)
📝 conformance/packages/conformance-tests/src/resolver/dns/scenarios/cname.rs (+11 -9)

...and 51 more files

📄 Description

From reviewing

#3211

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3216 **Author:** [@djc](https://github.com/djc) **Created:** 8/19/2025 **Status:** ✅ Merged **Merged:** 8/19/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `no-serde-with` --- ### 📝 Commits (5) - [`5fe117d`](https://github.com/hickory-dns/hickory-dns/commit/5fe117d0b99d482832e746d2aeefa0e8b68200b3) dns-test: simplify TransportLayer deserialization - [`fcbf0b6`](https://github.com/hickory-dns/hickory-dns/commit/fcbf0b6e1c39297463c60af5a7938034a9789dec) dns-test: simplify Ip deserialization - [`11694ab`](https://github.com/hickory-dns/hickory-dns/commit/11694ab0e4deb98279e917ec492d360d12bd6397) dns-test: drop lazy_static dependency in favor of LazyLock - [`af60f17`](https://github.com/hickory-dns/hickory-dns/commit/af60f17d52110b282673ceb572409ce8da023e33) conformance: avoid aliasing Result - [`b8281b0`](https://github.com/hickory-dns/hickory-dns/commit/b8281b01da2ba6d5577fa2716abca6229782dcd8) dns-test: drop CoreResult alias ### 📊 Changes **71 files changed** (+622 additions, -1817 deletions) <details> <summary>View changed files</summary> 📝 `conformance/Cargo.lock` (+0 -408) 📝 `conformance/packages/conformance-tests/src/forwarder/dns/scenarios.rs` (+3 -3) 📝 `conformance/packages/conformance-tests/src/forwarder/dnssec/scenarios.rs` (+4 -4) 📝 `conformance/packages/conformance-tests/src/forwarder/dnssec/scenarios/bogus.rs` (+3 -3) 📝 `conformance/packages/conformance-tests/src/name_server/rfc4035/section_3/section_3_1/section_3_1_1.rs` (+3 -3) 📝 `conformance/packages/conformance-tests/src/name_server/rfc5155.rs` (+9 -9) 📝 `conformance/packages/conformance-tests/src/name_server/rfc8906.rs` (+3 -3) 📝 `conformance/packages/conformance-tests/src/name_server/rfc8906/basic.rs` (+10 -10) 📝 `conformance/packages/conformance-tests/src/name_server/rfc8906/extended.rs` (+11 -11) 📝 `conformance/packages/conformance-tests/src/name_server/scenarios.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dns/regression.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dns/rfc1035/truncation.rs` (+5 -5) 📝 `conformance/packages/conformance-tests/src/resolver/dns/rfc3597.rs` (+3 -3) 📝 `conformance/packages/conformance-tests/src/resolver/dns/rfc8906.rs` (+5 -3) 📝 `conformance/packages/conformance-tests/src/resolver/dns/rfc8906/basic.rs` (+10 -10) 📝 `conformance/packages/conformance-tests/src/resolver/dns/rfc8906/extended.rs` (+11 -11) 📝 `conformance/packages/conformance-tests/src/resolver/dns/rfc9156.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dns/scenarios.rs` (+4 -4) 📝 `conformance/packages/conformance-tests/src/resolver/dns/scenarios/bad_referral.rs` (+5 -5) 📝 `conformance/packages/conformance-tests/src/resolver/dns/scenarios/cname.rs` (+11 -9) _...and 51 more files_ </details> ### 📄 Description From reviewing - #3211 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>