[PR #3210] [MERGED] resolver: make connection pool track servers #3645

New issue

Closed

opened 2026-03-16 11:55:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:55:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3210
Author: @djc
Created: 8/16/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @djc

Base: main ← Head: server-pool

📝 Commits (10+)

d1c430a resolver: rename NameServerStats to ConnectionMeta
415e975 resolver: drop Arc around ConnectionMeta::last_update
9fd835d resolver: move status into ConnectionMeta
576506a resolver: rename conn to server
c8a704b proto: move build_request() to DnsRequest::from_query()
fe98a66 proto: don't set default Edns version
e670c83 resolver: replace DnsHandle impl for NameServer with send() method
d1c2182 resolver: avoid unnecessary stream wrapping
b087c6d resolver: extract and clarify decaying SRTT interface
4f4d21c resolver: track connections per server

📊 Changes

9 files changed (+420 additions, -388 deletions)

View changed files

📝 conformance/conformance-tests/src/resolver/dnssec/scenarios/bogus.rs (+1 -0)
📝 conformance/e2e-tests/src/recursor/security/scenarios.rs (+12 -0)
📝 crates/proto/src/op/dns_request.rs (+34 -0)
📝 crates/proto/src/xfer/dns_handle.rs (+2 -35)
📝 crates/recursor/src/recursor_dns_handle.rs (+2 -2)
📝 crates/resolver/src/name_server/name_server.rs (+262 -225)
📝 crates/resolver/src/name_server/name_server_pool.rs (+49 -57)
📝 justfile (+1 -1)
📝 tests/integration-tests/tests/integration/name_server_pool_tests.rs (+57 -68)

📄 Description

See

#2738

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3210 **Author:** [@djc](https://github.com/djc) **Created:** 8/16/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `server-pool` --- ### 📝 Commits (10+) - [`d1c430a`](https://github.com/hickory-dns/hickory-dns/commit/d1c430a640804ba91e20ca03eab9082701711123) resolver: rename NameServerStats to ConnectionMeta - [`415e975`](https://github.com/hickory-dns/hickory-dns/commit/415e975fb3aa735f3946b0a7c8304deac992ed0f) resolver: drop Arc around ConnectionMeta::last_update - [`9fd835d`](https://github.com/hickory-dns/hickory-dns/commit/9fd835d0ce9652c32a29598d9b6cdd6218b18100) resolver: move status into ConnectionMeta - [`576506a`](https://github.com/hickory-dns/hickory-dns/commit/576506a662000df96a5c6a42410fd6952902789d) resolver: rename conn to server - [`c8a704b`](https://github.com/hickory-dns/hickory-dns/commit/c8a704b00b134cc693f2e1811c22d97d5440cba0) proto: move build_request() to DnsRequest::from_query() - [`fe98a66`](https://github.com/hickory-dns/hickory-dns/commit/fe98a66650e5fee03b027f0cf4669ad55266f27e) proto: don't set default Edns version - [`e670c83`](https://github.com/hickory-dns/hickory-dns/commit/e670c8377d0a9e7d793f801a7e288743db27323a) resolver: replace DnsHandle impl for NameServer with send() method - [`d1c2182`](https://github.com/hickory-dns/hickory-dns/commit/d1c2182e6d188e5e7066e1c74dbdacd27207438d) resolver: avoid unnecessary stream wrapping - [`b087c6d`](https://github.com/hickory-dns/hickory-dns/commit/b087c6d82257c62e64b91ce2962dcbaca8aa226e) resolver: extract and clarify decaying SRTT interface - [`4f4d21c`](https://github.com/hickory-dns/hickory-dns/commit/4f4d21ca09a0b8673a5d2809e40b1f05e375d738) resolver: track connections per server ### 📊 Changes **9 files changed** (+420 additions, -388 deletions) <details> <summary>View changed files</summary> 📝 `conformance/conformance-tests/src/resolver/dnssec/scenarios/bogus.rs` (+1 -0) 📝 `conformance/e2e-tests/src/recursor/security/scenarios.rs` (+12 -0) 📝 `crates/proto/src/op/dns_request.rs` (+34 -0) 📝 `crates/proto/src/xfer/dns_handle.rs` (+2 -35) 📝 `crates/recursor/src/recursor_dns_handle.rs` (+2 -2) 📝 `crates/resolver/src/name_server/name_server.rs` (+262 -225) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+49 -57) 📝 `justfile` (+1 -1) 📝 `tests/integration-tests/tests/integration/name_server_pool_tests.rs` (+57 -68) </details> ### 📄 Description See - #2738 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>