[PR #3206] [MERGED] Add associated type to DnsHandle for runtime #3641

New issue

Closed

opened 2026-03-16 11:54:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:54:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3206
Author: @divergentdave
Created: 8/14/2025
Status: ✅ Merged
Merged: 8/19/2025
Merged by: @divergentdave

Base: main ← Head: david/dnshandle-runtime-assoc-type

📝 Commits (2)

2194040 Add associated type to DnsHandle for runtime
b6e39c2 Rename type parameters

📊 Changes

41 files changed (+225 additions, -168 deletions)

View changed files

📝 bin/benches/comparison_benches.rs (+2 -2)
📝 bin/tests/integration/named_https_tests.rs (+1 -1)
📝 bin/tests/integration/named_metrics_tests.rs (+2 -2)
📝 bin/tests/integration/named_quic_tests.rs (+2 -1)
📝 bin/tests/integration/named_rustls_tests.rs (+2 -2)
📝 bin/tests/integration/named_test_rsa_dnssec.rs (+4 -4)
📝 bin/tests/integration/named_tests.rs (+20 -20)
📝 bin/tests/integration/server_harness/mod.rs (+7 -3)
📝 bin/tests/integration/server_harness/mut_message_client.rs (+1 -0)
📝 crates/client/README.md (+1 -1)
📝 crates/client/src/client/client.rs (+11 -10)
📝 crates/client/src/client/dnssec_client.rs (+4 -3)
📝 crates/client/src/client/memoize_client_handle.rs (+6 -4)
📝 crates/client/src/lib.rs (+1 -1)
📝 crates/client/src/tests.rs (+1 -1)
📝 crates/proto/src/dnssec/handle.rs (+1 -0)
📝 crates/proto/src/xfer/dns_exchange.rs (+53 -50)
📝 crates/proto/src/xfer/dns_handle.rs (+9 -3)
📝 crates/proto/src/xfer/mod.rs (+7 -3)
📝 crates/proto/src/xfer/retry_dns_handle.rs (+4 -1)

...and 21 more files

📄 Description

This adds an associated type to the DnsHandle trait for the runtime provider in use, and adds generic type parameters to implementors and other types as needed. This is preparatory work for #3158.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3206 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 8/14/2025 **Status:** ✅ Merged **Merged:** 8/19/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/dnshandle-runtime-assoc-type` --- ### 📝 Commits (2) - [`2194040`](https://github.com/hickory-dns/hickory-dns/commit/219404031198c48aa7ca73daefcdc7d609042c86) Add associated type to DnsHandle for runtime - [`b6e39c2`](https://github.com/hickory-dns/hickory-dns/commit/b6e39c2a9103f83cc14b74fb0d19994c7af06822) Rename type parameters ### 📊 Changes **41 files changed** (+225 additions, -168 deletions) <details> <summary>View changed files</summary> 📝 `bin/benches/comparison_benches.rs` (+2 -2) 📝 `bin/tests/integration/named_https_tests.rs` (+1 -1) 📝 `bin/tests/integration/named_metrics_tests.rs` (+2 -2) 📝 `bin/tests/integration/named_quic_tests.rs` (+2 -1) 📝 `bin/tests/integration/named_rustls_tests.rs` (+2 -2) 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+4 -4) 📝 `bin/tests/integration/named_tests.rs` (+20 -20) 📝 `bin/tests/integration/server_harness/mod.rs` (+7 -3) 📝 `bin/tests/integration/server_harness/mut_message_client.rs` (+1 -0) 📝 `crates/client/README.md` (+1 -1) 📝 `crates/client/src/client/client.rs` (+11 -10) 📝 `crates/client/src/client/dnssec_client.rs` (+4 -3) 📝 `crates/client/src/client/memoize_client_handle.rs` (+6 -4) 📝 `crates/client/src/lib.rs` (+1 -1) 📝 `crates/client/src/tests.rs` (+1 -1) 📝 `crates/proto/src/dnssec/handle.rs` (+1 -0) 📝 `crates/proto/src/xfer/dns_exchange.rs` (+53 -50) 📝 `crates/proto/src/xfer/dns_handle.rs` (+9 -3) 📝 `crates/proto/src/xfer/mod.rs` (+7 -3) 📝 `crates/proto/src/xfer/retry_dns_handle.rs` (+4 -1) _...and 21 more files_ </details> ### 📄 Description This adds an associated type to the `DnsHandle` trait for the runtime provider in use, and adds generic type parameters to implementors and other types as needed. This is preparatory work for #3158. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>