[PR #3187] [MERGED] Simplify objects in build_forwarded_response() #3626

New issue

Closed

opened 2026-03-16 11:53:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:53:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3187
Author: @divergentdave
Created: 8/8/2025
Status: ✅ Merged
Merged: 8/8/2025
Merged by: @divergentdave

Base: main ← Head: david/simplify-build-forwarded-response

📝 Commits (2)

5666d6f Rename variables
f2aaf43 Simplify objects in build_forwarded_response()

📊 Changes

1 file changed (+10 additions, -13 deletions)

View changed files

📝 crates/server/src/authority/catalog.rs (+10 -13)

📄 Description

This refactors a couple places in build_forwarded_response() to use the simpler LookupRecords::Section instead of LookupRecords::ManyRecords, which required wrapping individual records in fictional RecordSets.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3187 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 8/8/2025 **Status:** ✅ Merged **Merged:** 8/8/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/simplify-build-forwarded-response` --- ### 📝 Commits (2) - [`5666d6f`](https://github.com/hickory-dns/hickory-dns/commit/5666d6f8e2f101094d46d10708f04d021cd9b201) Rename variables - [`f2aaf43`](https://github.com/hickory-dns/hickory-dns/commit/f2aaf43d5827d00db1f802834dbd1ed7317278e7) Simplify objects in build_forwarded_response() ### 📊 Changes **1 file changed** (+10 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/authority/catalog.rs` (+10 -13) </details> ### 📄 Description This refactors a couple places in `build_forwarded_response()` to use the simpler `LookupRecords::Section` instead of `LookupRecords::ManyRecords`, which required wrapping individual records in fictional `RecordSet`s. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>