[PR #3181] [MERGED] fix nightly unused_parens warns, tidy retry_dns_handle.rs #3621

New issue

Closed

opened 2026-03-16 11:53:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:53:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3181
Author: @cpu
Created: 8/7/2025
Status: ✅ Merged
Merged: 8/7/2025
Merged by: @cpu

Base: main ← Head: cpu-tidy-retry-dns-handle_dev

📝 Commits (2)

d50e3c2 fix nightly unused_parens warns
0b18315 proto: tidy retry_dns_handle std/no-std-rand gating

📊 Changes

3 files changed (+63 additions, -65 deletions)

View changed files

📝 crates/client/src/client/dnssec_client.rs (+1 -1)
📝 crates/proto/src/xfer/retry_dns_handle.rs (+61 -63)
📝 crates/server/src/authority/catalog.rs (+1 -1)

📄 Description

Quick follow-up to https://github.com/hickory-dns/hickory-dns/pull/3180

Proactively takes care of a couple of nightly only warns, and cleans up the retry_dns_handle.rs to try and avoid so many #[cfg] annotations.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3181 **Author:** [@cpu](https://github.com/cpu) **Created:** 8/7/2025 **Status:** ✅ Merged **Merged:** 8/7/2025 **Merged by:** [@cpu](https://github.com/cpu) **Base:** `main` ← **Head:** `cpu-tidy-retry-dns-handle_dev` --- ### 📝 Commits (2) - [`d50e3c2`](https://github.com/hickory-dns/hickory-dns/commit/d50e3c293b527d9c63a8b5fcaacb9a7717250ab7) fix nightly unused_parens warns - [`0b18315`](https://github.com/hickory-dns/hickory-dns/commit/0b1831505d686244cef46cc4fb1f20159b21ef9b) proto: tidy retry_dns_handle std/no-std-rand gating ### 📊 Changes **3 files changed** (+63 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/client/dnssec_client.rs` (+1 -1) 📝 `crates/proto/src/xfer/retry_dns_handle.rs` (+61 -63) 📝 `crates/server/src/authority/catalog.rs` (+1 -1) </details> ### 📄 Description Quick follow-up to https://github.com/hickory-dns/hickory-dns/pull/3180 Proactively takes care of a couple of nightly only warns, and cleans up the `retry_dns_handle.rs` to try and avoid so many `#[cfg]` annotations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>