[PR #3180] [MERGED] Fix lints with Rust 1.89 toolchain #3619

Closed
opened 2026-03-16 11:53:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3180
Author: @divergentdave
Created: 8/7/2025
Status: Merged
Merged: 8/7/2025
Merged by: @divergentdave

Base: mainHead: david/rust-1-89-lints


📝 Commits (3)

  • fe6b7b0 Make all of RetrySendStream conditional on feature
  • 030d99b Remove unnecessary unwrap
  • b007cc6 Remove unnecessary clone

📊 Changes

3 files changed (+14 additions, -7 deletions)

View changed files

📝 crates/proto/src/xfer/retry_dns_handle.rs (+7 -0)
📝 crates/server/src/authority/catalog.rs (+5 -6)
📝 tests/integration-tests/tests/integration/name_server_pool_tests.rs (+2 -1)

📄 Description

This fixes three lints that show up with the latest stable toolchain.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3180 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 8/7/2025 **Status:** ✅ Merged **Merged:** 8/7/2025 **Merged by:** [@divergentdave](https://github.com/divergentdave) **Base:** `main` ← **Head:** `david/rust-1-89-lints` --- ### 📝 Commits (3) - [`fe6b7b0`](https://github.com/hickory-dns/hickory-dns/commit/fe6b7b0832af15e69737b359e727a9f675267184) Make all of RetrySendStream conditional on feature - [`030d99b`](https://github.com/hickory-dns/hickory-dns/commit/030d99b43402a81b8fcc9fa490183e6956b67053) Remove unnecessary unwrap - [`b007cc6`](https://github.com/hickory-dns/hickory-dns/commit/b007cc6c6ae2f039f4718b5cfc3620c61da6c7f2) Remove unnecessary clone ### 📊 Changes **3 files changed** (+14 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/xfer/retry_dns_handle.rs` (+7 -0) 📝 `crates/server/src/authority/catalog.rs` (+5 -6) 📝 `tests/integration-tests/tests/integration/name_server_pool_tests.rs` (+2 -1) </details> ### 📄 Description This fixes three lints that show up with the latest stable toolchain. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:53:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3619
No description provided.